Skip to content

[Shipping Labels] Fix product icon color #15564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2025

Conversation

RafaelKayumov
Copy link
Contributor

@RafaelKayumov RafaelKayumov commented Apr 28, 2025

Closes: WOOMOB-81

Description

Applies template rendering mode for product and shipment icons to follow the color scheme.

Steps to reproduce

  • Enable dark mode
  • Log in to a test store with Woo Shipping plugin set up.
  • Navigate to the Orders tab and select a completed order with several physical products.
  • Tap on "Create shipping labels".
  • Open the "Shipment details" bottom sheet.
  • The "product" icon on "N items" row must contrast with the background and be readable.

Screenshots

Before After
Снимок экрана 2025-04-30 в 15 34 18 Снимок экрана 2025-04-30 в 15 31 55

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

@RafaelKayumov RafaelKayumov added type: bug A confirmed bug. feature: shipping labels Related to creating, ordering, or printing shipping labels. labels Apr 28, 2025
@RafaelKayumov RafaelKayumov added this to the 22.3 milestone Apr 28, 2025
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Apr 28, 2025

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Number29592
VersionPR #15564
Bundle IDcom.automattic.alpha.woocommerce
Commit4bbdd48
Installation URL72hpda1hbm690
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@RafaelKayumov RafaelKayumov marked this pull request as ready for review April 28, 2025 16:20
Copy link
Contributor

@itsmeichigo itsmeichigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. I wonder if we should really replace the icon though, as it looks bolder than the original design:

Screenshot 2025-04-29 at 11 19 09

I notice another icon below that's not supported in dark mode either. This would show up if you add a shipping line in the order creation step by tapping Add Shipping.

@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is assigned to the milestone 22.3. This milestone is due in less than 2 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@RafaelKayumov RafaelKayumov force-pushed the WOOMOB-81-fix-product-icon-color branch from c38419e to 4bbdd48 Compare April 30, 2025 12:38
Copy link
Contributor

@itsmeichigo itsmeichigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and confirmed that both icons look correctly in both light and dark modes.
I'll proceed to merge this PR.

@itsmeichigo itsmeichigo merged commit 6a4312d into trunk May 2, 2025
13 checks passed
@itsmeichigo itsmeichigo deleted the WOOMOB-81-fix-product-icon-color branch May 2, 2025 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: shipping labels Related to creating, ordering, or printing shipping labels. type: bug A confirmed bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants