Skip to content

[Woo POS][Products Search] Let recent searches scroll over floating buttons #15582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

joshheald
Copy link
Contributor

@joshheald joshheald commented Apr 30, 2025

Closes: WOOMOB-389

Description

This PR adds padding when required to allow all recent searches to be visible over floating buttons.

Steps to reproduce

  1. Launch the app and go to POS
  2. Open search
  3. Add 9+ search history items (search for a term, then tap an item in the results)
  4. Clear the last search if needed to see the search history
  5. Dismiss the keyboard
  6. Scroll the recent searches – observe that you can see all the search history.

Testing information

I've tested on an iPad Air running iOS 17.7.2

Screenshots

padding.to.clear.floating.buttons.in.recent.searches.mp4

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

@joshheald joshheald added type: task An internally driven task. feature: POS labels Apr 30, 2025
@joshheald joshheald added this to the 22.3 milestone Apr 30, 2025
@joshheald joshheald changed the title Let recent searches scroll over floating buttons [Woo POS][Products Search] Let recent searches scroll over floating buttons Apr 30, 2025
@joshheald joshheald requested a review from jaclync April 30, 2025 15:09
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is assigned to the milestone 22.3. This milestone is due in less than 2 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Number29599
VersionPR #15582
Bundle IDcom.automattic.alpha.woocommerce
Commitc7a275a
Installation URL7jf9igklkqlj8
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@joshheald joshheald requested a review from staskus May 1, 2025 08:53
Copy link
Contributor

@staskus staskus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well, iPad Air 11 18.4 👍

Copy link
Contributor

@jaclync jaclync left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests well! Merging it for code freeze.

@jaclync jaclync merged commit 6b37924 into trunk May 2, 2025
22 of 25 checks passed
@jaclync jaclync deleted the woomob-389-woo-posproducts-search-recent-items-hidden-behind-floating branch May 2, 2025 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: POS type: task An internally driven task.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants