Skip to content

Throw a "data too large" error in ListMapper when parsing data bigger than a certain size like 100MB #15780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Conversation

jaclync
Copy link
Contributor

@jaclync jaclync commented Jun 19, 2025

Why

When the response size is large like in the support case in WOOMOB-607 with a large amount of product metadata, the UI could become unresponsive. Other than moving the response parsing to a background thread, the client can also prevent the app from taking up unexpectedly large amount of device resources in case of receiving exceedingly large data.

TODO: still figuring out a way to show appropriate error UX, and maybe disable max size check by default.

Description

Steps to reproduce

Testing information

Screenshots


  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@jaclync jaclync added this to the 22.7 milestone Jun 19, 2025
@jaclync jaclync added the type: task An internally driven task. label Jun 19, 2025
@dangermattic
Copy link
Collaborator

1 Message
📖 This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jun 19, 2025

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Number30578
VersionPR #15780
Bundle IDcom.automattic.alpha.woocommerce
Commit590505c
Installation URL1f5o8321e6ri8
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@wpmobilebot wpmobilebot modified the milestones: 22.7, 22.8 Jun 27, 2025
@wpmobilebot
Copy link
Collaborator

Version 22.7 has now entered code-freeze, so the milestone of this PR has been updated to 22.8.

@wpmobilebot wpmobilebot modified the milestones: 22.8, 22.9 Jul 11, 2025
@wpmobilebot
Copy link
Collaborator

Version 22.8 has now entered code-freeze, so the milestone of this PR has been updated to 22.9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task An internally driven task.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants