Skip to content

Fix broken build by updating fileprivate extension access #15909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2025

Conversation

iamgabrielma
Copy link
Contributor

@iamgabrielma iamgabrielma commented Jul 15, 2025

Description

After merging #15891 into trunk it seems a conflict sneaked through, making the build to not compile due to SalesChannelFilter' is not a member type of class 'WooCommerce.FilterOrderListViewModel' error.

This is an update that was made here and was merged into trunk before #15891, without pulling the latests updates from trunk.

Changes

Updated access to analyticsDescription from FilterOrderListViewModel.SalesChannelFilter to SalesChannelFilter

Testing information

  • Build should compile. CI should pass.
  • Feel free to skip this is you have no POS setup: If you do, you can confirm that tapping on Orders > Filters > Sales Channel > Point of Sale > Show Orders still tracks the event with the sales_channel: pos property, as:
🔵 Tracked orders_list_filter, properties: [plan: , is_wpcom_store: false, blog_id: -1, store_id: c5bd46cc-1804-4f7b-badb-bb98c449127f, site_url: https://indiemelon.mystagingwebsite.com, sales_channel: pos, was_ecommerce_trial: false]

@iamgabrielma iamgabrielma added type: bug A confirmed bug. type: task An internally driven task. feature: order list Related to the order list. labels Jul 15, 2025
@iamgabrielma iamgabrielma added this to the 22.9 milestone Jul 15, 2025
@iamgabrielma iamgabrielma requested a review from a team July 15, 2025 04:13
@wpmobilebot
Copy link
Collaborator

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr15909-93224a1
Version22.8
Bundle IDcom.automattic.alpha.woocommerce
Commit93224a1
Installation URL5mp8f1f78alq8
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@iamgabrielma iamgabrielma enabled auto-merge July 15, 2025 04:41
@iamgabrielma iamgabrielma merged commit a1128f3 into trunk Jul 15, 2025
25 of 27 checks passed
@iamgabrielma iamgabrielma deleted the fix/broken-build-from-15891-merge branch July 15, 2025 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: order list Related to the order list. type: bug A confirmed bug. type: task An internally driven task.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants