Reader: Add new ReaderPostHeaderView#25463
Merged
Merged
Conversation
Collaborator
Generated by 🚫 Danger |
kean
force-pushed
the
task/reader-adaptive-post-header-view
branch
from
00c49a2 to
e64a372
Compare
|
Contributor
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 31838 | |
| Version | PR #25463 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | e64a372 | |
| Installation URL | 154ia2rplq7c8 |
Contributor
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 31838 | |
| Version | PR #25463 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | e64a372 | |
| Installation URL | 180rblp835gh0 |
jkmassel
approved these changes
Apr 10, 2026
jkmassel
left a comment
jkmassel
left a comment
Contributor
There was a problem hiding this comment.
Looks good pending some accessibility stuff
|
|
||
| // MARK: - Subviews | ||
|
|
||
| private let siteNameLabel: UILabel = { |
Contributor
There was a problem hiding this comment.
This is tappable – should it be marked as such for accessibility?
| return stack | ||
| }() | ||
|
|
||
| private lazy var authorRow: UIStackView = { |
Contributor
There was a problem hiding this comment.
This has a gesture recognizer attached later – should it be marked tappable for accessibility purposes?
Contributor
|
Version |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is first part of CMM-1999: Reader: Adaptive Post Details Page, which adds the new
ReaderPostHeaderViewto theWordPressReadermodule. It is implemented inUIKitbecause the rest of the screen is, and it requires manual frame manipulations: when the header resizes, it needs to update the container (scroll view) – it required too many extra steps with SwiftUI judging by the original implementation.