Add the ability to import and export saved posts.#25509
Open
Add the ability to import and export saved posts.#25509
Conversation
Collaborator
Generated by 🚫 Danger |
Contributor
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 32156 | |
| Version | PR #25509 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 1209432 | |
| Installation URL | 22p1kqpfvmif0 |
Contributor
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 32156 | |
| Version | PR #25509 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 1209432 | |
| Installation URL | 1bfo3j95c0oc0 |
twstokes
force-pushed
the
reader-import-export
branch
from
d2b6618 to
8209a08
Compare
twstokes
force-pushed
the
reader-import-export
branch
from
3b1a46f to
06c723d
Compare
Contributor
🤖 Build Failure AnalysisThis build has failures. Claude has analyzed them - check the build annotations for details. |
twstokes
force-pushed
the
reader-import-export
branch
from
06c723d to
6f4c403
Compare
Lets the VM be unit-tested without ContextManager.shared, and marks the alert message strings @published so SwiftUI re-reads them when the isShowing* flag flips.
Adds three Tracks events: - reader_saved_posts_settings_shown when the screen appears - reader_saved_posts_exported on a successful export - reader_saved_posts_imported with imported/skipped/failed counts
jkmassel
reviewed
May 9, 2026
Comment on lines
+49
to
+50
| let appName = (Bundle.main.object(forInfoDictionaryKey: "CFBundleDisplayName") as? String) ?? "WordPress" | ||
| let appVersion = Bundle.main.object(forInfoDictionaryKey: "CFBundleShortVersionString") as? String |
Contributor
There was a problem hiding this comment.
These can be force-unwrapped – we'd never ship a release that doesn't have them.
Realistically we should have a helper that does it for you 🤷
crazytonyli
reviewed
May 10, 2026
| import WordPressData | ||
|
|
||
| /// Handles exporting and importing saved Reader posts as JSON files. | ||
| struct ReaderSavedPostsExporter { |
Contributor
There was a problem hiding this comment.
The implementation does not quite follow the patterns used widely in the app. I have added a doc in #25551. I wonder if you can prompt AI to rewrite to follow the updated best practices?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
{AppName}-Saved-Posts-{date}.jsonfile containing post metadata (URL, title, author, site, date, summary, tags, featured image, siteID, postID) along with the app version that exported it.ReaderPostServicepipeline to create fully-populated Core Data objects. Posts are fetched sequentially to avoid race conditions. Deduplication usespermaLink— posts whose URL is already saved are skipped, so importing the same file multiple times or merging lists from different devices is safe.Test plan
🤖 Generated with Claude Code