-
Notifications
You must be signed in to change notification settings - Fork 20
Au/iris workers NUMA-awareness (POP-2820) #1594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1c66217
to
93e0852
Compare
mcalancea
approved these changes
Sep 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
@carlomazzaferro Should we merge this? Pro: first iteration of NUMA. Con: possibly none, or slightly slower startup. (edited) |
@mcalancea @carlomazzaferro Probably worth reviewing again now. The new approach no longer has this previous problem around blocking channels. |
naure
added a commit
that referenced
this pull request
Sep 15, 2025
Merged
mcalancea
pushed a commit
that referenced
this pull request
Sep 25, 2025
* Deploy dev with #1594 and #1634 (and more) * Au/dev tune (#1666) au/dev-tune: Adjust HAWK parameters * au/dev-tune: connection_parallelism=16 * au/ Balance OT Roles (POP-2917) (#1675) au/balance-ot-roles * dev: Deploy au/tune-params * au/disable round counter (POP-2876) (#1646) * au/disable-round-counter * au/disable-round-counter: Count MPC rounds with FastHistogram * au/reserve-extra (POP-2874) (#1647) au/reserve-extra * au/tune-params: lower parallelism params (#1677) * au/write_all (#1645) * Au/no wait send (POP-2878) (#1644) * au/fast-metrics * au/net-metrics: More networking metrics (#1629) * au/fast-metrics: Remove unused GRPC metrics * au/fast-metrics: Remove networking changes * au/network-metrics: Add fast metrics to the networking * au/no-wait-send: Send packets earlier and do not spin * dev: deploy same as stage * dev: build docker * dev: deploy * dev: Don’t build on deploy commands
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arc
will be made from the worker threads, which optimistically tends to allocate on the NUMA node of the thread.HAWK_NUMA
true/false (default true).