Skip to content

Conversation

carlomazzaferro
Copy link
Collaborator

@carlomazzaferro carlomazzaferro commented Sep 15, 2025

We will pivot to arm images, so we need a CI flow to build such image on main. Further, we want to test the latest features from main on arm.

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codex Review: Here are some suggestions.

Reply with @codex fix comments to fix any unresolved comments.

About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".

Comment on lines 47 to 52
tags: |
${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:${{ github.sha }}-arm64
${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:latest-arm64
${{ github.event.release.tag_name && format('{0}/{1}:{2}', env.REGISTRY, env.IMAGE_NAME, github.event.release.tag_name) || '' }}
platforms: linux/amd64
build-args: |

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P1] Build job tags AMD64 image as ARM64

The new workflow advertises itself as producing an ARM64 image (tags append -arm64), but the build step is configured with platforms: linux/amd64. This will push an x86_64 image under ARM-specific tags whenever the workflow runs, so any ARM runner pulling :latest-arm64 will receive the wrong architecture and fail to start. Update platforms to linux/arm64 (or remove it to default to the runner’s arch) so the published image matches the tag.

Useful? React with 👍 / 👎.

@carlomazzaferro carlomazzaferro merged commit eb0fa49 into main Sep 16, 2025
14 checks passed
@carlomazzaferro carlomazzaferro deleted the test/latest-features-numa branch September 16, 2025 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants