[POP-2962] batch rotation aware dot products #1714
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdwoodbury
force-pushed
the
sw/batch_trick_dot
branch
from
f45f7b1 to
b09c12b
Compare
sdwoodbury
force-pushed
the
sw/batch_trick_dot
branch
from
b09c12b to
546f1ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds a
rotation_aware_dot_product_batch()function toiris_worker.Using this function within
Aby3Store::eval_distance_batch()will break the unit and integration tests.However, when it is time to update the
Aby3Store, all that needs to be done is replacedot_product_batch()withrotation_aware_dot_product_batch().