Skip to content

Conversation

naure
Copy link
Collaborator

@naure naure commented Oct 9, 2025

/// The master switch to enable search-per-rotation or search-center-only.
pub type SearchRotations = AllRotations;

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request refactors the rotation support system to use more descriptive names and better abstractions. The changes replace the generic "WithRot"/"WithoutRot" types with semantically clearer "AllRotations"/"CenterOnly" types and rename "VecRots" to "VecRotationSupport" to better reflect its purpose.

Key changes:

  • Renamed rotation support types from WithRot/WithoutRot to AllRotations/CenterOnly
  • Renamed VecRots to VecRotationSupport with improved documentation
  • Added SearchRotations type alias and VecRotations convenience type for consistent configuration

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
iris-mpc-cpu/src/execution/hawk_main/rot.rs Core refactoring of rotation support types and better documentation
iris-mpc-cpu/src/execution/hawk_main.rs Added master configuration types and updated all references
iris-mpc-cpu/src/execution/hawk_main/search.rs Updated type aliases to use new rotation support types
iris-mpc-cpu/src/execution/hawk_main/scheduler.rs Updated function signatures and constructor calls
iris-mpc-cpu/src/execution/hawk_main/reset.rs Updated to use CenterOnly type and explicit generic parameters
iris-mpc-cpu/src/execution/hawk_main/matching.rs Updated imports and type references, added proper rotation constant usage
iris-mpc-cpu/src/execution/hawk_main/is_match_batch.rs Updated type signatures and method calls
iris-mpc-cpu/src/execution/hawk_main/intra_batch.rs Updated to use new rotation support API for getting rotation count

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment on lines +19 to +20
pub type SearchQueries<ROT> = Arc<BothEyes<VecRequests<VecRotationSupport<Aby3Query, ROT>>>>;
pub type SearchResults<ROT> = BothEyes<VecRequests<VecRotationSupport<HawkInsertPlan, ROT>>>;
Copy link

Copilot AI Oct 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The generic parameter ROT no longer has a default value, which is a breaking change for any code that uses these type aliases without explicitly specifying the rotation type.

Copilot uses AI. Check for mistakes.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants