-
Notifications
You must be signed in to change notification settings - Fork 20
refactor tcp stack and add graceful shutdown #1729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
sdwoodbury
wants to merge
48
commits into
dev
Choose a base branch
from
sw/new_tcp_stack2
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
iris-mpc
terminates and to halt a job when the networking stack experiences an error.This PR initially set out to add graceful shutdown and job cancellation to the networking stack.
iris-mpc
is shut down, the networking stack should clean up without emitting false positive error logsIt became clear that while the process of creating a connection needs to retry, once the connections are established, they need not automatically reconnect. Reconnect can be initiated when the sessions are recreated.
This allows the connection manager and reconnector to be removed. it also allows the connection management code to be simplified.
The logic to connect, handshake, and forward messages is unchanged.