Skip to content

node(governor): Remove duplication in unit test set-up #4430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

node(governor): Remove duplication in unit test set-up #4430

wants to merge 1 commit into from
+48 −121

Conversation

johnsaigle
Copy link
Contributor

  • Pass a testing instance to the set-up function and exit early on nil/err conditions rather than making each individual test perform this action

@johnsaigle
node(governor): Remove duplication in unit test set-up
7b9ae43 
- Pass a testing instance to the set-up function and exit early on
  nil/err conditions rather than making each individual test perform
  this action
@johnsaigle johnsaigle added governor quality doesn't fix a known bug, doesn't change behavior, but increase code quality test labels Jul 11, 2025
@johnsaigle johnsaigle marked this pull request as ready for review July 11, 2025 18:11
djb15
djb15 reviewed Jul 18, 2025
View reviewed changes
node/pkg/governor/governor_test.go
gov := NewChainGovernor(logger, &db, common.GoTest, true, "")

err := gov.Run(ctx)
if err != nil {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove the if statements for all of these now where you're calling into require.NoError

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djb15 djb15 djb15 left review comments

@SEJeff SEJeff Awaiting requested review from SEJeff SEJeff is a code owner

@mdulin2 mdulin2 Awaiting requested review from mdulin2 mdulin2 is a code owner

@pleasew8t pleasew8t Awaiting requested review from pleasew8t pleasew8t is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
governor quality doesn't fix a known bug, doesn't change behavior, but increase code quality test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnsaigle @djb15