node(governor): add some type safety; rename decimals to scalingFactor #4471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
johnsaigle
commented
Aug 14, 2025
johnsaigle
commented
- Change TokenConfigEntry.Decimals field from int64 to uint8 for more appropriate data type
- Rename tokenEntry.decimals to scalingFactor with clarifying comment explaining it represents 10^decimals
- Add comprehensive error checking in computeValue function to prevent nil pointer dereferences and division by zero
- Add test cases to validate token prices are positive and decimals are within sensible bounds (0-24)
johnsaigle
added
governor
quality
- Change TokenConfigEntry.Decimals field from int64 to uint8 for more appropriate data type - Rename tokenEntry.decimals to scalingFactor with clarifying comment explaining it represents 10^decimals - Add comprehensive error checking in computeValue function to prevent nil pointer dereferences and division by zero - Add test cases to validate token prices are positive and decimals are within sensible bounds (0-24)
johnsaigle
force-pushed
the
governor-type-safety-and-scalingfactor
branch
from
60df009 to
752dbdf
Compare
johnsaigle
requested review from
SEJeff,
djb15,
mdulin2 and
pleasew8t
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.