node: Log version on watcher start #4472
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djb15
force-pushed
the
log-version-on-watcher-start
branch
2 times, most recently
from
c049d5f to
ad548f4
Compare
johnsaigle
approved these changes
Aug 18, 2025
djb15
force-pushed
the
log-version-on-watcher-start
branch
from
ad548f4 to
99952a2
Compare
|
@djb15 is it maybe worth emitting a gauge or something as well in where one of the tags is the version? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @SEJeff for #2520 from which this is based.
This has been tested manually for every watcher in Tilt devnet to confirm we get the expected output.
I have also deliberately induced a panic in a
logVersionmethod and confirmed that CI fails. For watchers without tests, the watcher will boot loop in Tilt and eventually timeout. The new changes are designed in such a way that if the version can't be fetched successfully an error is logged and the watcher continues as normal.