notary: Add admin rescue commands #4474
Conversation
…bridge validation - Replace TxID-based deduplication with MessageID for pending message queue - Add emitter address validation for token bridge transfers - Fix test helper functions to generate unique messages with proper sequence numbers - Add duplicate prevention tests and improve error handling
…token bridges are not given a bad ruling
- Add commands to change the status of delayed and blackholed messages in the Notary - Change Notary commands to use MessageID consistently instead of a combination of pointers to MessagePublication and VAAHash
johnsaigle
force-pushed
the
notary-rescue
branch
from
a18ad48 to
4fb9de5
Compare
| } | ||
|
|
||
| return &nodev1.NotaryBlackholeDelayedMessageResponse{ | ||
| Response: "Blackholed message", |
There was a problem hiding this comment.
Can you add in the vaaId string into the responses?
| } | ||
|
|
||
| // RemoveBlackholedMsg removes a message from the blackholed list and deletes it from the database. | ||
| func (n *Notary) RemoveBlackholedMsg(msgID string) error { |
There was a problem hiding this comment.
Should we add such messages that are removed from the blackholed list to the pending queue with 0 release time to ensure they are processed? I'm going to guess a reobservation would most likely lead to the message being blackholed again
| string response = 1; | ||
| } | ||
|
|
||
| message NotaryResetReleaseTimerRequest { |
There was a problem hiding this comment.
Missing the admin command for this message
|
|
||
| // When a message is blackholed, it should be removed from the delayed list and database. | ||
| err := n.removeDelayed(msg) | ||
| err := n.removeDelayed(msg.MessageID()) |
There was a problem hiding this comment.
Probably applies to the notary PR rather than this one, but should we attempt to remove from the delayed list + database before adding to the blackholed list? Just in case the removal fails we don't want the message in both places
|
Now that the Notary has been merged, this is in my court to rebase and fix-up. In doing so I'll go back and respond to the comments |
in the Notary
combination of pointers to MessagePublication and VAAHash
This PR is based on #4315 and will stay in draft until that PR is merged.