ci(gocritic): refactor so that new rules will get included automatically #4497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnsaigle
requested review from
evan-gray,
panoel,
SEJeff and
djb15
as code owners
mdulin2
approved these changes
Sep 23, 2025
johnsaigle
force-pushed
the
gocritic-enable-all
branch
from
4aa6a2b to
7c6cbe6
Compare
djb15
approved these changes
Sep 23, 2025
johnsaigle
force-pushed
the
gocritic-enable-all
branch
from
7c6cbe6 to
6d4fb4b
Compare
|
@panoel Would you mind reviewing? |
johnsaigle
force-pushed
the
gocritic-enable-all
branch
2 times, most recently
from
70e6597 to
7046c31
Compare
…les will get run - Ensures that all rules are enabled by default with a deny-list, instead of disabling all rules and using an allow-list. This change allows us to benefit from new rules that could be added to gocritic in the future. Our current policy in CI is to fail on new rules and this is already in place for e.g. clippy lints for new Rust releases.
johnsaigle
force-pushed
the
gocritic-enable-all
branch
from
7046c31 to
bbf11f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures that all rules are enabled by default with a deny-list,
instead of disabling all rules and using an allow-list. This change
allows us to benefit from new rules that could be added to gocritic in
the future. Our current policy in CI is to fail on new rules and this
is already in place for e.g. clippy lints for new Rust releases.