wp post create: Add JSON input support for tax_input
#532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes this 10 year old issue wp-cli/wp-cli#1323 (closed, but not fixed). `wp post create` parameter `--tax_input` is supposed to be an array, but no JSON parsing is done and therefore is unusable.
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
|
Thanks for opening this PR. Would you also be up for adding some tests to cover this change? See #133 for inspiration. |
|
I just added a test now, but it fails because Related: https://github.com/orgs/wp-cli/discussions/6052 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes this 10 year old issue wp-cli/wp-cli#1323 (closed, but not fixed).
wp post createparameter--tax_inputis supposed to be an array, but no JSON parsing is done and therefore is unusable.