Merge pull request #5 from mecha/fix/4_has-false-positive-expired

Fixes `has` false-positive for expired transients

Author: XedinUnknown

src/CachePool.php

@@ -197,8 +197,7 @@ public function deleteMultiple($keys)
     public function has($key)
     {
         $default = $this->defaultValue;
-        $prefix = $this->getOptionNamePrefix();
-        $value = $this->getOption("{$prefix}{$key}", $default);
+        $value = $this->get($key, $default);
 
         return $value !== $default;
     }

tests/functional/CachePoolTest.php

@@ -342,18 +342,16 @@ public function testHas()
             $defaultValue = uniqid('default');
             $wpdb = $this->createWpdb();
             $key = uniqid('key');
-            $separator = TestSubject::NAMESPACE_SEPARATOR;
-            $transientName = "{$poolName}{$separator}{$key}";
-            $optionName = "_transient_$transientName";
             $notThereKey = uniqid('not-there');
-            $notThereTransientName = "{$poolName}{$separator}{$notThereKey}";
-            $notThereOptionName = "_transient_$notThereTransientName";
-            $subject = $this->createInstance($wpdb, $poolName,$defaultValue );
+            $subject = $this->createInstance($wpdb, $poolName, $defaultValue);
         }
 
         {
+            Functions\expect('get_transient')
+                ->andReturnValues([uniqid('value'), false]);
+
             Functions\expect('get_option')
-                ->andReturnValues([uniqid('value'), $defaultValue]);
+                ->andReturnValues([$defaultValue]);
         }
 
         {