-
Notifications
You must be signed in to change notification settings - Fork 40
Rewrite using new Aperture and n-api #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
karaggeorge
wants to merge
27
commits into
main
Choose a base branch
from
george/rewrite-using-napi
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
004ba5d
Rewrite using new Aperture and n-api
karaggeorge 90d3b0f
Update macos image
karaggeorge 125c0a8
Attempt to build both targets
karaggeorge bd2c74b
Fix workflows
karaggeorge 01598e7
Use only native bindings
karaggeorge 1e569b8
Fix import path
karaggeorge 3f3d9df
Attempt to run tests on Intel mac
karaggeorge c154427
Fix build command
karaggeorge 1762f32
Print os info in test
karaggeorge d853a48
Debug permissions
karaggeorge e41c3fa
Debug permissions
karaggeorge 1a296ba
Find process
karaggeorge e6613a4
Find process
karaggeorge c0ce47e
Re-enable tests
karaggeorge 3bb9970
Fix workflow
karaggeorge 0154f65
Remove xo temporarily
karaggeorge 0f231fb
Try to run tests on Intel
karaggeorge aa19366
Bring back cross-platform build
karaggeorge 5a90466
Update api
karaggeorge 50a8df8
Update readme
karaggeorge 054a28e
Fix types and example
karaggeorge ff7cbef
Cleanup exports
karaggeorge 335b643
Version bump
karaggeorge a6b14d7
Bump Aperture to 3.0.0
karaggeorge 9799d31
Fix some errors and docs
karaggeorge f5c1cc7
Rename targetId -> targetID
karaggeorge 3b8ee06
Remove unused dependencies
karaggeorge File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,21 +1,50 @@ | ||
name: CI | ||
on: | ||
- push | ||
- pull_request | ||
# - pull_request | ||
jobs: | ||
test: | ||
name: Node.js ${{ matrix.node-version }} | ||
runs-on: macos-14 | ||
runs-on: macos-15 | ||
strategy: | ||
fail-fast: false | ||
matrix: | ||
node-version: | ||
- 20 | ||
- 18 | ||
# - 18 | ||
steps: | ||
- uses: actions/checkout@v4 | ||
- uses: actions/setup-node@v4 | ||
with: | ||
node-version: ${{ matrix.node-version }} | ||
- run: npm install | ||
- run: npm run build | ||
- run: npm test | ||
- name: Upload build | ||
uses: actions/upload-artifact@v3 | ||
with: | ||
name: binding-artifact-${{ matrix.node-version }} | ||
path: build | ||
|
||
test-intel: | ||
needs: [test] | ||
name: Node.js ${{ matrix.node-version }} (Intel) | ||
runs-on: macos-13 | ||
strategy: | ||
fail-fast: false | ||
matrix: | ||
node-version: | ||
- 20 | ||
# - 18 | ||
steps: | ||
- uses: actions/checkout@v4 | ||
- uses: actions/setup-node@v4 | ||
with: | ||
node-version: ${{ matrix.node-version }} | ||
- run: npm install | ||
- name: Download build | ||
uses: actions/download-artifact@v3 | ||
with: | ||
name: binding-artifact-${{ matrix.node-version }} | ||
path: build | ||
- run: npm test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||
---|---|---|---|---|---|---|---|---|
@@ -0,0 +1,6 @@ | ||||||||
parent_config: https://raw.githubusercontent.com/sindresorhus/swiftlint-config/main/.swiftlint.yml | ||||||||
deployment_target: | ||||||||
macOS_deployment_target: '13' | ||||||||
excluded: | ||||||||
- .build | ||||||||
- node_modules | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.