Reference package instead of project in samples

Author: gunndabad

.github/workflows/ci.yml

@@ -70,14 +70,14 @@ jobs:
             exit 1
           fi
 
-      - name: Build samples
-        run: just build-samples --configuration Release
-
       - name: Pack
         run: just pack --configuration Release
         env:
           MINVERBUILDMETADATA: ${{ env.GITHUB_RUN_NUMBER }}
 
+      - name: Build samples
+        run: just build-samples --configuration Release
+
       - name: Publish package artifact
         uses: actions/upload-artifact@v4
         with:

Directory.Build.targets

@@ -1,16 +1,9 @@
 <Project>
-  <PropertyGroup>
-    <BuildDependsOn>
-      CleanPackages;
-      $(BuildDependsOn)
-    </BuildDependsOn>
-  </PropertyGroup>
-
-  <Target Name="CleanPackages" Condition="'$(PackageId)' != ''">
-    <ItemGroup>
-      <_OldPackages Include="$(PackageOutputPath)/$(PackageId)*" />
-    </ItemGroup>
+  <ItemGroup>
+    <_OldPackages Include="$(PackageOutputPath)/$(PackageId)*" />
+  </ItemGroup>
 
+  <Target Name="CleanPackages" Condition="'$(PackageId)' != ''" AfterTargets="Pack">
     <Delete Files="@(_OldPackages)" />
   </Target>
 </Project>

samples/Samples.DateInput/Samples.DateInput.csproj

@@ -5,11 +5,8 @@
   </PropertyGroup>
 
   <ItemGroup>
+    <PackageReference Include="GovUk.Frontend.AspNetCore" Version="3.2.*-*" />
     <PackageReference Include="NodaTime" Version="3.0.5" />
   </ItemGroup>
 
-  <ItemGroup>
-    <ProjectReference Include="..\..\src\GovUk.Frontend.AspNetCore\GovUk.Frontend.AspNetCore.csproj" />
-  </ItemGroup>
-
 </Project>

samples/Samples.MvcStarter/Samples.MvcStarter.csproj

@@ -6,11 +6,8 @@
   </PropertyGroup>
 
   <ItemGroup>
+    <PackageReference Include="GovUk.Frontend.AspNetCore" Version="3.2.*-*" />
     <PackageReference Include="Joonasw.AspNetCore.SecurityHeaders" Version="4.0.1" />
   </ItemGroup>
 
-  <ItemGroup>
-    <ProjectReference Include="..\..\src\GovUk.Frontend.AspNetCore\GovUk.Frontend.AspNetCore.csproj" />
-  </ItemGroup>
-
 </Project>

samples/Samples.sln

@@ -7,6 +7,11 @@ Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Samples.DateInput", "Sample
 EndProject
 Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Samples.MvcStarter", "Samples.MvcStarter\Samples.MvcStarter.csproj", "{5C74E1B9-459A-43CD-8B93-164DBCD0B047}"
 EndProject
+Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution Items", "{C8202507-F5B1-46FC-85EF-56A9BE1ADB87}"
+	ProjectSection(SolutionItems) = preProject
+		nuget.config = nuget.config
+	EndProjectSection
+EndProject
 Global
 	GlobalSection(SolutionConfigurationPlatforms) = preSolution
 		Debug|Any CPU = Debug|Any CPU

samples/nuget.config

@@ -0,0 +1,14 @@
+<?xml version="1.0" encoding="utf-8"?>
+<configuration>
+  <packageSources>
+    <add key="local" value="../packages" />
+  </packageSources>
+  <packageSourceMapping>
+    <packageSource key="nuget.org">
+      <package pattern="*" />
+    </packageSource>
+    <packageSource key="local">
+      <package pattern="GovUk.Frontend.AspNetCore" />
+    </packageSource>
+  </packageSourceMapping>
+</configuration>