Fix duplicate PathBase in OpengraphImageUrl

gunndabad · gunndabad · commit 3b694eb9f7d7 · 2024-12-10T17:45:44.000Z
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Changelog
 
+## Unreleased
+
+Fix duplicate `PathBase` in OpengraphImageUrl in page template view.
+
 ## 2.2.0
 
 Targets GOV.UK Frontend v5.2.0.
diff --git a/src/GovUk.Frontend.AspNetCore/Views/Shared/_GovUkPageTemplate.cshtml b/src/GovUk.Frontend.AspNetCore/Views/Shared/_GovUkPageTemplate.cshtml
@@ -15,7 +15,7 @@
 
     var htmlLang = ViewBag.HtmlLang ?? "en";
     var themeColor = ViewBag.ThemeColor ?? "#0b0c0c";
-    var ogImage = ViewBag.OpengraphImageUrl ?? $"{Context.Request.Scheme}://{Context.Request.Host}{Context.Request.PathBase}{assetPath}/images/govuk-opengraph-image.png";
+    var ogImage = ViewBag.OpengraphImageUrl ?? $"{Context.Request.Scheme}://{Context.Request.Host}{assetPath}/images/govuk-opengraph-image.png";
 }
 <!DOCTYPE html>
 <html lang="@htmlLang" class="govuk-template @ViewBag.HtmlClasses">

Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,7 @@`
`15`	`15`
`16`	`16`	`var htmlLang = ViewBag.HtmlLang ?? "en";`
`17`	`17`	`var themeColor = ViewBag.ThemeColor ?? "#0b0c0c";`
`18`		`- var ogImage = ViewBag.OpengraphImageUrl ?? $"{Context.Request.Scheme}://{Context.Request.Host}{Context.Request.PathBase}{assetPath}/images/govuk-opengraph-image.png";`
	`18`	`+ var ogImage = ViewBag.OpengraphImageUrl ?? $"{Context.Request.Scheme}://{Context.Request.Host}{assetPath}/images/govuk-opengraph-image.png";`
`19`	`19`	`}`
`20`	`20`	`<!DOCTYPE html>`
`21`	`21`	`<html lang="@htmlLang" class="govuk-template @ViewBag.HtmlClasses">`