Enable All analyzers on primary project

Author: gunndabad

.editorconfig

@@ -11,6 +11,7 @@ insert_final_newline = true
 indent_size = 4
 dotnet_sort_system_directives_first = true
 csharp_style_namespace_declarations = file_scoped:warning
+dotnet_analyzer_diagnostic.category-Style.severity = warning
 dotnet_diagnostic.IDE0005.severity = warning
 resharper_redundant_empty_object_creation_argument_list_highlighting = none
 

src/GovUk.Frontend.AspNetCore/AttributeDictionaryExtensions.cs

@@ -7,6 +7,8 @@ namespace GovUk.Frontend.AspNetCore;
 /// </summary>
 internal static class AttributeDictionaryExtensions
 {
+    private static readonly char[] _classSeparator = [' '];
+
     /// <summary>
     /// Adds a CSS class to the list of CSS classes in the tag if it does not already specified.
     /// If there are already CSS classes on the tag then a space character and the new class will be appended to
@@ -25,7 +27,7 @@ public static void MergeCssClass(this AttributeDictionary attributeDictionary, s
 
         if (attributeDictionary.TryGetValue("class", out var currentValue))
         {
-            var classes = currentValue!.Split(new[] { ' ' }, StringSplitOptions.RemoveEmptyEntries);
+            var classes = currentValue!.Split(_classSeparator, StringSplitOptions.RemoveEmptyEntries);
 
             if (!classes.Contains(value, StringComparer.OrdinalIgnoreCase))
             {

src/GovUk.Frontend.AspNetCore/ComponentGeneration/AttributeCollection.cs

@@ -61,6 +61,7 @@ public AttributeCollection(IEnumerable<TagHelperAttribute> tagHelperAttributes)
     internal AttributeCollection(IEnumerable<Attribute> attributes)
     {
         ArgumentNullException.ThrowIfNull(attributes);
+
         _attributes = attributes.ToDictionary(a => a.Name, a => a);
     }
 

src/GovUk.Frontend.AspNetCore/ComponentGeneration/DefaultComponentGenerator.Functions.cs

@@ -1,3 +1,4 @@
+using System.Globalization;
 using System.Text;
 using Fluid;
 using Fluid.Values;
@@ -137,7 +138,7 @@ public static FluidValue GovukI18nAttributes(FunctionArguments args, TemplateCon
                     var pluralRule = pluralRuleParts[0].ToStringValue();
                     var message = pluralRuleParts[1].ToStringValue();
 
-                    sb.Append($" data-i18n.{key}.{pluralRule}=\"{_encoder.Encode(message)}\"");
+                    sb.Append(CultureInfo.InvariantCulture, $" data-i18n.{key}.{pluralRule}=\"{_encoder.Encode(message)}\"");
                 }
 
                 return new StringValue(sb.ToString(), encode: false);
@@ -172,7 +173,7 @@ public static FluidValue Not(FunctionArguments args, TemplateContext context)
             return FluidValue.Create(!args.At(0).ToBooleanValue(), context.Options);
         }
 
-        public static FluidValue String(FunctionArguments args, TemplateContext context)
+        public static StringValue String(FunctionArguments args, TemplateContext context)
         {
             return StringValue.Create(args.At(0).ToStringValue());
         }

src/GovUk.Frontend.AspNetCore/ComponentGeneration/DefaultComponentGenerator.cs

@@ -66,7 +66,7 @@ public DefaultComponentGenerator(IRazorViewEngine viewEngine, IHttpContextAccess
             }
 
             // If the object is an Options class, convert its property names to camel case
-            if (v.GetType().Namespace?.StartsWith(GetType().Namespace!) == true && !v.GetType().IsArray)
+            if (v.GetType().Namespace?.StartsWith(GetType().Namespace!, StringComparison.Ordinal) == true && !v.GetType().IsArray)
             {
                 return new ConvertNamesFromJsonTypeInfoObjectValue(v, optionsJsonSerializerOptions);
             }

src/GovUk.Frontend.AspNetCore/ComponentGeneration/TemplateString.cs

@@ -88,15 +88,19 @@ internal FluidValue ToFluidValue(HtmlEncoder encoder)
     /// <param name="value">The unencoded <see cref="String"/>.</param>
     /// <returns></returns>
     [return: NotNullIfNotNull(nameof(value))]
+#pragma warning disable CA2225
     public static implicit operator TemplateString?(string? value) => value is null ? null : new(value);
+#pragma warning restore CA2225
 
     /// <summary>
     /// Creates a <see cref="TemplateString"/> from <see cref="HtmlString"/>.
     /// </summary>
     /// <param name="content">The <see cref="IHtmlContent"/> to create the <see cref="TemplateString"/> from.</param>
     /// <returns>A new <see cref="TemplateString"/> wrapping the specified <see cref="HtmlString"/>.</returns>
     [return: NotNullIfNotNull(nameof(content))]
+#pragma warning disable CA2225
     public static implicit operator TemplateString?(HtmlString? content) => content is null ? null : new(content);
+#pragma warning restore CA2225
 
 #pragma warning disable CS1591 // Missing XML comment for publicly visible type or member
     public static bool operator ==(TemplateString? first, TemplateString? second) =>
@@ -164,6 +168,7 @@ public static class TemplateStringExtensions
     public static TemplateString AppendCssClasses(this TemplateString? templateString, HtmlEncoder encoder, params TemplateString[] classNames)
     {
         ArgumentNullException.ThrowIfNull(encoder);
+        ArgumentNullException.ThrowIfNull(classNames);
 
         var original = templateString?.ToHtmlString(encoder).Trim() ?? "";
 

src/GovUk.Frontend.AspNetCore/ComponentGeneration/Templates/GovUkComponentView.cs

@@ -9,6 +9,8 @@ public abstract class GovUkComponentView<TModel> : RazorPage<TModel>
 {
     protected IHtmlContent? Classes(params object?[] classNames)
     {
+        ArgumentNullException.ThrowIfNull(classNames);
+
         if (classNames.Length == 0)
         {
             return null;

src/GovUk.Frontend.AspNetCore/ComponentGeneration/Templates/TagHelpers/AttributesTagHelper.cs

@@ -12,6 +12,9 @@ public class AttributesTagHelper : TagHelper
 
     public override void Process(TagHelperContext context, TagHelperOutput output)
     {
+        ArgumentNullException.ThrowIfNull(context);
+        ArgumentNullException.ThrowIfNull(output);
+
         if (Attributes is null)
         {
             return;

src/GovUk.Frontend.AspNetCore/ComponentGeneration/Templates/TagHelpers/TrimContentTagHelper.cs

@@ -9,6 +9,9 @@ public class TrimContentTagHelper : TagHelper
 {
     public override async Task ProcessAsync(TagHelperContext context, TagHelperOutput output)
     {
+        ArgumentNullException.ThrowIfNull(context);
+        ArgumentNullException.ThrowIfNull(output);
+
         var content = (await output.GetChildContentAsync()).GetContent();
         output.Content.SetHtmlContent(content.Trim());
         output.Attributes.RemoveAll("_gfa-trim-content");

src/GovUk.Frontend.AspNetCore/DefaultModelHelper.cs

@@ -8,16 +8,11 @@ internal class DefaultModelHelper : IModelHelper
 {
     private delegate string GetFullHtmlFieldNameDelegate(ViewContext viewContext, string expression);
 
-    private static readonly GetFullHtmlFieldNameDelegate s_getFullHtmlFieldNameDelegate;
-
-    static DefaultModelHelper()
-    {
-        s_getFullHtmlFieldNameDelegate =
-            (GetFullHtmlFieldNameDelegate)typeof(IHtmlGenerator).Assembly
-                .GetType("Microsoft.AspNetCore.Mvc.ViewFeatures.NameAndIdProvider", throwOnError: true)!
-                .GetMethod("GetFullHtmlFieldName", System.Reflection.BindingFlags.Public | System.Reflection.BindingFlags.Static)!
-                .CreateDelegate(typeof(GetFullHtmlFieldNameDelegate));
-    }
+    private static readonly GetFullHtmlFieldNameDelegate _getFullHtmlFieldNameDelegate =
+        (GetFullHtmlFieldNameDelegate)typeof(IHtmlGenerator).Assembly
+            .GetType("Microsoft.AspNetCore.Mvc.ViewFeatures.NameAndIdProvider", throwOnError: true)!
+            .GetMethod("GetFullHtmlFieldName", System.Reflection.BindingFlags.Public | System.Reflection.BindingFlags.Static)!
+            .CreateDelegate(typeof(GetFullHtmlFieldNameDelegate));
 
     public virtual string? GetDescription(ModelExplorer modelExplorer) => modelExplorer.Metadata.Description;
 
@@ -42,7 +37,7 @@ public virtual string GetFullHtmlFieldName(ViewContext viewContext, string expre
         ArgumentNullException.ThrowIfNull(viewContext);
         ArgumentNullException.ThrowIfNull(expression);
 
-        return s_getFullHtmlFieldNameDelegate(viewContext, expression);
+        return _getFullHtmlFieldNameDelegate(viewContext, expression);
     }
 
     public virtual string? GetModelValue(ViewContext viewContext, ModelExplorer modelExplorer, string expression)