Skip to content

Conversation

dubmarm
Copy link
Contributor

@dubmarm dubmarm commented Feb 19, 2025

The PR is to fix an issue with configib that fails to configure an IB connection if it already exists

The modification include

files altered: xCAT/postscripts/configib

  1. Take out a useless segment of arp_ignore and arp_filter that was clearing any sysctl.conf
  2. Create a logic to perform nmcli con add if the $nic doesnt exist ELSE perform nmcli con modify
    • Otherwise an error is thrown stating a duplicate con exists with the same name and the adjustments dont occur

@CLAassistant
Copy link

CLAassistant commented Feb 19, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ dubmarm
❌ dmarm


dmarm seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Obihoernchen
Copy link
Member

Thank you for this PR!
Can you please sign the CA?
Thank you!

@Obihoernchen
Copy link
Member

@dubmarm could you please sign the CLA and revert the arp_ignore changes? Then I'll merge this.

@dubmarm
Copy link
Contributor Author

dubmarm commented May 27, 2025

I did sign the CLA, the webpage shows a little grey'ed out chckbox that says I signed it. Regarding reverting the arp_ignore I can do that.

@Obihoernchen
Copy link
Member

Looks like you did use another mail for your commits. That's fine.
Yes, please revert the arp_ignore changes, then I can merge this PR.

@dubmarm
Copy link
Contributor Author

dubmarm commented May 27, 2025

  1. I added my work email to my profile
  2. I reverted the changes to line 391-394.

This should be good if you agree

@Obihoernchen Obihoernchen merged commit ee5479c into xcat2:master May 27, 2025
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants