feat: add size proof field in datalayer metadata #296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yakuhito
reviewed
Sep 8, 2025
| @@ -113,6 +114,7 @@ pub struct DataStoreMetadata { | |||
| pub label: Option<String>, | |||
| pub description: Option<String>, | |||
| pub bytes: Option<u64>, | |||
| pub size_proof: Option<Bytes32>, | |||
There was a problem hiding this comment.
are you 100% certain that size proofs will be 32 bytes long?
There was a problem hiding this comment.
this should have been string like the description. this was fixed
Yakuhito
reviewed
Sep 8, 2025
| @@ -125,6 +127,7 @@ impl<N, D: ClvmDecoder<Node = N>> FromClvm<D> for DataStoreMetadata { | |||
| "l" => metadata.label = Some(String::from_clvm(decoder, ptr)?), | |||
| "d" => metadata.description = Some(String::from_clvm(decoder, ptr)?), | |||
| "b" => metadata.bytes = Some(u64::from_clvm(decoder, ptr)?), | |||
| "p" => metadata.size_proof = Some(Bytes32::from_clvm(decoder, ptr)?), | |||
There was a problem hiding this comment.
easy to mistake with CATalog precision; I would suggest sp
Yakuhito
reviewed
Sep 8, 2025
| @@ -149,6 +152,10 @@ impl<N, E: ClvmEncoder<Node = N>> ToClvm<E> for DataStoreMetadata { | |||
| items.push(("b", Raw(bytes.to_clvm(encoder)?))); | |||
| } | |||
|
|
|||
| if let Some(size_proof) = self.size_proof { | |||
| items.push(("p", Raw(size_proof.to_clvm(encoder)?))); | |||
Rigidity
approved these changes
Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new metadata field to the datalayer store singleton called "size_proof"