Skip to content

Conversation

Rigidity
Copy link
Collaborator

No description provided.

@Rigidity Rigidity requested a review from Yakuhito August 17, 2024 05:44
Copy link

codecov bot commented Aug 17, 2024

Codecov Report

Attention: Patch coverage is 61.45251% with 69 lines in your changes missing coverage. Please review.

Project coverage is 67.04%. Comparing base (0e2127e) to head (67c48a7).
Report is 8 commits behind head on main.

Files Patch % Lines
...driver/src/layers/p2_delegated_conditions_layer.rs 0.00% 16 Missing ⚠️
crates/chia-sdk-types/src/condition.rs 23.80% 16 Missing ⚠️
...rates/chia-sdk-driver/src/layers/standard_layer.rs 54.54% 10 Missing ⚠️
...ates/chia-sdk-types/src/condition/announcements.rs 0.00% 6 Missing ⚠️
crates/chia-sdk-driver/src/primitives/launcher.rs 69.23% 4 Missing ⚠️
crates/chia-sdk-driver/src/spend_context.rs 83.33% 4 Missing ⚠️
crates/chia-sdk-types/src/conditions.rs 75.00% 4 Missing ⚠️
crates/chia-sdk-driver/src/primitives/nft.rs 76.92% 3 Missing ⚠️
...tes/chia-sdk-driver/src/primitives/nft_launcher.rs 60.00% 2 Missing ⚠️
...a-sdk-types/src/puzzles/p2_delegated_conditions.rs 0.00% 2 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #61      +/-   ##
==========================================
- Coverage   67.67%   67.04%   -0.64%     
==========================================
  Files          51       55       +4     
  Lines        1878     1872       -6     
==========================================
- Hits         1271     1255      -16     
- Misses        607      617      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


// This lint is ignored since semantically we want spends to consume Conditions.
#[allow(clippy::needless_pass_by_value)]
pub fn spend(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you plan to add hidden_spend now or in the future? :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably in the future

@Rigidity Rigidity merged commit 2ce0f2a into main Aug 17, 2024
1 of 3 checks passed
@Rigidity Rigidity deleted the p2-layers branch August 17, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants