-
Notifications
You must be signed in to change notification settings - Fork 88
python project configuration for koji scripts #733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
13a2b2e to
9a30b4e
Compare
|
Does this incur a change for current users of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The info in the commit message would be useful in a README, and maybe uvx can be suggested for install?
Currently it only display a warning about the file location that has been changed. But that's not mandatory. |
| @@ -0,0 +1 @@ | |||
| 3.11.11 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the point of this file? This version can't be enforced (my system doesn't provide it)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uv uses it to pin the python version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the point of this file? This version can't be enforced (my system doesn't provide it.
uv should install that exact version for you. That's not the case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I install tools using uv tool, I've never seen it installing python version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feels strange, as https://docs.astral.sh/uv/guides/tools/ says uv tool run is the same as uvx, and
Tools are installed into temporary, isolated environments when using uvx.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the system python matches the version allowed in pyproject.toml, I don't see why it would be strange to use the system interpreter
0d39503 to
7427a6a
Compare
f9405d1 to
9ae3dc1
Compare
Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>
Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>
Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>
9ae3dc1 to
c16a69e
Compare
|
I removed myself from the reviewers. There are two approvals, looks like it can be rebased and then merged. |
We can now
uv syncin the dir, andexport PATH=$PWD/.venv/bin:$PATHto usekoji-buildwith its required dependency.The package should also be publishable, allowing, in the future, to
pipx install koji-utilsto havekoji-buildand the other tools available in the shell.Note that I had to move
koji_build.pyto a module directory. The rootkoji_build.pynow prints a warning saying it's been moved, but we could also not print any warning.