-
Notifications
You must be signed in to change notification settings - Fork 350
encode & decode 32-bit float (IEEE 754 standard) samples. #842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aliheidary1381
wants to merge
3
commits into
xiph:master
Choose a base branch
from
aliheidary1381:float-sample-coding
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -178,6 +178,9 @@ extern FLAC_API const uint32_t FLAC__STREAM_SYNC_LEN; /* = 32 bits */ | |
| /** The length of the FLAC signature in bytes. */ | ||
| #define FLAC__STREAM_SYNC_LENGTH (4u) | ||
|
|
||
| typedef enum { NOT_SPECIFIED = -1, | ||
| INT = 0, | ||
| FLOAT = 1 } SampleType; // TODO: merge with endian & unsigned | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The name of the type should be FLAC__SampleType, to follow naming style |
||
|
|
||
| /***************************************************************************** | ||
| * | ||
|
|
@@ -431,6 +434,11 @@ typedef struct { | |
| uint32_t bits_per_sample; | ||
| /**< The sample resolution. */ | ||
|
|
||
| #if ENABLE_EXPERIMENTAL_FLOAT_SAMPLE_CODING | ||
| SampleType sample_type; | ||
| /**< FLOAT if the samples are IEEE 754 binary32 (32-bit floating point) */ | ||
| #endif | ||
|
|
||
| FLAC__FrameNumberType number_type; | ||
| /**< The numbering scheme used for the frame. As a convenience, the | ||
| * decoder will always convert a frame number to a sample number because | ||
|
|
@@ -539,6 +547,9 @@ typedef struct { | |
| uint32_t sample_rate; | ||
| uint32_t channels; | ||
| uint32_t bits_per_sample; | ||
| #if ENABLE_EXPERIMENTAL_FLOAT_SAMPLE_CODING | ||
| SampleType sample_type; | ||
| #endif | ||
| FLAC__uint64 total_samples; | ||
| FLAC__byte md5sum[16]; | ||
| } FLAC__StreamMetadata_StreamInfo; | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| option(ENABLE_64_BIT_WORDS "Set FLAC__BYTES_PER_WORD to 8, for 64-bit machines. For 32-bit machines, turning this off might give a tiny speed improvement" ON) | ||
| option(ENABLE_EXPERIMENTAL_FLOAT_SAMPLE_CODING "Enable experimental feature to encode & decode 32-bit float (IEEE 754 standard) samples" ON) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should be OFF by default? |
||
| option(BUILD_UTILS "Build utils" OFF) | ||
|
|
||
| add_subdirectory("libFLAC") | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is put into the global scope/namespace, I suggest to add a prefix like SAMPLE_TYPE_ for all enum values, or even FLAC__SAMPLE_TYPE_.
Especially INT is a bit too short and too common name as to not be confusing.