antlr4: fix rules #7007
antlr4: fix rules #7007
Conversation
| end | ||
| elseif grammar_name then | ||
| table.insert(batchcxx.sourcefiles, path.join(sourcefile_dir, grammar_name .. "Parser.cpp")) | ||
| table.insert(batchcxx.sourcefiles, path.join(sourcefile_dir, grammar_name .. "Lexer.cpp")) |
There was a problem hiding this comment.
@waruqi 目前单个 job 里有两个 cxx file 并不会并行编译，这里该怎么优化
There was a problem hiding this comment.
参考的 idl 那个 rule? 感觉你这里参数不对，少了 jobgraph 参数
按理里面默认都会并行的。。idl 那个也有问题，估计得改
There was a problem hiding this comment.
idl 那个确实有很多问题，我等会修
There was a problem hiding this comment.
参考的 idl 那个 rule? 感觉你这里参数不对，少了 jobgraph 参数
local dependfile = target:objectfile(objectfile)这行为什么这么写，有点怪怪的
There was a problem hiding this comment.
试了一下，应该直接用 private.action.build.object main 来给每个 cxx 添加 job
There was a problem hiding this comment.
on_build_files 开头用 group 包一层有什么区别么？
There was a problem hiding this comment.
on_build_files 开头用 group 包一层有什么区别么？
你可以不包，这不是必须的，如果你想让其他 job 依赖这些 build files 的整体顺序调整，可以 group 下，然后通过一个 jobgraph:add_orders 去调整统一顺序，而不是挨个 build file 一个 job ，去单独调整顺序
There was a problem hiding this comment.
不要去参考那个 idl rule ，那个也是人家贡献进来的，很多写的都不对，这些 group 都可以去掉
可以参考 verilator 那个 rule ，就没包
packages/a/antlr4/rules/g4.lua
Outdated
| end) | ||
| end | ||
| end) | ||
| end, {jobgraph = true, batch = true, distcc = true}) |
There was a problem hiding this comment.
这里已经用上了 jobgraph 接口，完全不兼容 batch 了，就没必要启用 batch = true 了。。
另外，3.0 都还没 release ，都没 jobgraph 支持，直接改，不会 break 现有用户么？
There was a problem hiding this comment.
所以我下面也写了一个 batchcmd 版的，但好像没有很好的办法让 xmake2 优先选择使用
|
还有一个问题，下游 target 依赖 codgen 出来的头文件，设置 [ 13%]: compiling.release src\main.cpp
[ 18%]: compiling.g4 src\g4\LuaLexer.g4
[ 22%]: compiling.g4 src\g4\LuaParser.g4
[ 27%]: compiling.release build\.gens\antlr4-lua\windows\x64\release\rules\antlr4\src\g4\LuaLexer.cpp
[ 31%]: compiling.release build\.gens\antlr4-lua\windows\x64\release\rules\antlr4\src\g4\LuaParser.cpp
[ 36%]: compiling.release src\visitor\Visitor.cpp
[ 40%]: compiling.release src\LuaLexerBase.cpp
error: main.cpp
src\main.cpp(3): fatal error C1083: Cannot open include file: 'LuaLexer.h': No such file or directorymain.cpp 是下游 target 里的文件 |
There is another problem. The downstream target depends on the header file produced by codgen, and setting |
那是因为，你里面有源码间的依赖。 codegen 完，直接编译成 .o 插入 objectfiles，而不是生成完，丢给 on_buildfiles 去混入当前编译，缺少源码间的 job 依赖关系，你没指定。 另外，across_targets_in_parallel 废弃了，改用 build.fence，不过目前是兼容的，按理应该可以的。 另外，如果要加源码间以来，可以通过 group name / job name + jobgraph:add_orders 你自己配置上去。。 也可以改用 on_prepare_files 里面去做 codegen ，on_build_files 里面去 build ，就不用配置 jobgraph 顺序，完全隔离的 |
That's because you have dependencies between source codes. After codegen, directly compile it into .o and insert objectfiles, instead of generating it, throw it to on_buildfiles to mix in the current compilation. It lacks the job dependency between the source code, you did not specify it. In addition, across_targets_in_parallel is abandoned and used instead with build.fence, but it is currently compatible, which should be OK. In addition, if you want to add source code, you can configure it yourself through group name / job name + jobgraph:add_orders. . You can also use on_prepare_files to do codegen and on_build_files to build. You don't need to configure the jobgraph order and are completely isolated. |
这是因为你 rules 里面没加 add_orders 去配置 rules 间的依赖执行顺序，那么即使设置 build.fence 也没用。 比如： 当然，直接设置 on_prepare_files 会更简单些 |
This is because you don't add_orders to configure the dependency execution order between rules, so even setting build.fence is useless. For example: Of course, it would be easier to set on_prepare_files directly |
close #6965