Skip to content

Commit a60ad5f

Browse files
committed
continue to optimize building targets
1 parent 5166d71 commit a60ad5f

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

tests/benchmarks/build_targets/test.lua

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ function test_build(t)
2424
os.runv(cmake.program, {"--build", "."}, {curdir = "build"})
2525
cmake_default_dt = os.mclock() - cmake_default_dt
2626
print("build targets/30: cmake/default: %d ms", cmake_default_dt)
27-
--t:require((cmake_default_dt > xmake_dt) or (cmake_default_dt + 2000 > xmake_dt))
27+
t:require((cmake_default_dt > xmake_dt) or (cmake_default_dt + 2000 > xmake_dt))
2828

2929
local ninja = find_tool("ninja")
3030
if ninja then
@@ -46,8 +46,7 @@ function test_build(t)
4646
os.runv(cmake.program, {"--build", "."}, {curdir = "build", envs = envs})
4747
cmake_ninja_dt = os.mclock() - cmake_ninja_dt
4848
print("build targets/30: cmake/ninja: %d ms", cmake_ninja_dt)
49-
-- TODO we need to improve it
50-
--t:require((cmake_ninja_dt > xmake_dt) or (cmake_ninja_dt + 2000 > xmake_dt))
49+
t:require((cmake_ninja_dt > xmake_dt) or (cmake_ninja_dt + 2000 > xmake_dt))
5150
end
5251

5352
local make = find_tool("make")
@@ -72,7 +71,7 @@ function test_build(t)
7271
os.runv(meson.program, {"compile", "-C", "build"})
7372
meson_dt = os.mclock() - meson_dt
7473
print("build targets/30: meson: %d ms", meson_dt)
75-
--t:require((meson_dt > xmake_dt) or (meson_dt + 2000 > xmake_dt))
74+
t:require((meson_dt > xmake_dt) or (meson_dt + 2000 > xmake_dt))
7675
end
7776
end
7877

0 commit comments

Comments
 (0)