Skip to content

Conversation

Arthapz
Copy link
Member

@Arthapz Arthapz commented Sep 11, 2025

this PR allow the user setting the path of WDK directory and only assert for the missing binaries when they are needed (for exemple nuget WDK doesn't ship all of these binary)

@waruqi
Copy link
Member

waruqi commented Sep 12, 2025

xmake don't currently have a way to set the WDK rootdir

why do not use xmake f --wdk=rootdir?

local wdk = _find_wdk(sdkdir or config.get("wdk") or global.get("wdk") or config.get("sdk"), opt.version or config.get("wdk_sdkver"))

Using set_values ​​to set hard-coded paths is not recommended.

and we can also use set_config("wdk", "rootdir") to set it.

@Arthapz Arthapz force-pushed the enable-custom-wdk-path branch from 5e2a050 to e031b87 Compare September 12, 2025 20:00
@Arthapz
Copy link
Member Author

Arthapz commented Sep 12, 2025

xmake don't currently have a way to set the WDK rootdir

why do not use xmake f --wdk=rootdir?

local wdk = _find_wdk(sdkdir or config.get("wdk") or global.get("wdk") or config.get("sdk"), opt.version or config.get("wdk_sdkver"))

Using set_values ​​to set hard-coded paths is not recommended.

and we can also use set_config("wdk", "rootdir") to set it.

my bad didn't saw it :D, i removed bits about wdk directory

@Arthapz Arthapz changed the title feat(wdk rules) enable support of externals wdk feat(wdk rules) enable support of incomplete wdk Sep 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants