Skip to content

Commit 5b4c779

Browse files
committed
Remove guard clause double-checking for readonly
1 parent 8dbdd04 commit 5b4c779

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

ChangeLog.md

+5
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,11 @@ XP Compiler ChangeLog
33

44
## ?.?.? / ????-??-??
55

6+
* Merged PR #184: Add support for final properties added in PHP 8.4, see
7+
https://wiki.php.net/rfc/property-hooks; including parameter promotion,
8+
see https://wiki.php.net/rfc/final_promotion
9+
(@thekid)
10+
611
## 9.3.3 / 2025-03-02
712

813
* Fixed callable new syntax when using a variable or expression, e.g.

src/main/php/lang/ast/emit/ReadonlyProperties.class.php

-2
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,6 @@ trait ReadonlyProperties {
2222
use VisibilityChecks;
2323

2424
protected function emitProperty($result, $property) {
25-
if (!in_array('readonly', $property->modifiers)) return parent::emitProperty($result, $property);
26-
2725
$scope= $result->codegen->scope[0];
2826
$modifiers= Modifiers::bits($property->modifiers);
2927
$scope->meta[self::PROPERTY][$property->name]= [

0 commit comments

Comments
 (0)