Add tests for datetime and datetime4 types

Sybase and MSSQL have different semantics for calculating seconds

(cherry picked from commit ec108fd)

Author: thekid

src/main/php/rdbms/tds/TdsProtocol.class.php

@@ -209,6 +209,16 @@ public function unmarshal($stream, $field, $records) {
         return $this->toFloat($stream->read(4));
       }
     }');
+    self::$recordsFor[0][self::T_DATE]= newinstance('rdbms.tds.TdsRecord', [], '{
+      public function unmarshal($stream, $field, $records) {
+        return $this->toDate($stream->getLong(), 0);
+      }
+    }');
+    self::$recordsFor[0][self::T_DATETIME]= newinstance('rdbms.tds.TdsRecord', [], '{
+      public function unmarshal($stream, $field, $records) {
+        return $this->toDate($stream->getLong(), $stream->getLong() / 300);
+      }
+    }');
     self::$recordsFor[0][self::T_MONEYN]= newinstance('rdbms.tds.TdsRecord', [], '{
       public function unmarshal($stream, $field, $records) {
         $len= isset($field["len"]) ? $field["len"] : $stream->getByte();

src/main/php/rdbms/tds/TdsV5Protocol.class.php

@@ -91,16 +91,6 @@ public function unmarshal($stream, $field, $records) {
         } 
       }
     }');
-    self::$recordsFor[0][self::T_DATE]= newinstance('rdbms.tds.TdsRecord', [], '{
-      public function unmarshal($stream, $field, $records) {
-        return $this->toDate($stream->getLong(), 0);
-      }
-    }');
-    self::$recordsFor[0][self::T_DATETIME]= newinstance('rdbms.tds.TdsRecord', [], '{
-      public function unmarshal($stream, $field, $records) {
-        return $this->toDate($stream->getLong(), $stream->getLong());
-      }
-    }');
     self::$recordsFor[0][self::T_DATETIME4]= newinstance('rdbms.tds.TdsRecord', [], '{
       public function unmarshal($stream, $field, $records) {
         return $this->toDate($stream->getShort(), $stream->getShort() * 60);

src/main/php/rdbms/tds/TdsV7Protocol.class.php

@@ -114,16 +114,6 @@ public function unmarshal($stream, $field, $records) {
         return 0xFFFF === $len ? null : iconv("ucs-2le", \xp::ENCODING, $stream->read($len));
       }
     }');
-    self::$recordsFor[0][self::T_DATE]= newinstance('rdbms.tds.TdsRecord', [], '{
-      public function unmarshal($stream, $field, $records) {
-        return $this->toDate($stream->getLong(), 0);
-      }
-    }');
-    self::$recordsFor[0][self::T_DATETIME]= newinstance('rdbms.tds.TdsRecord', [], '{
-      public function unmarshal($stream, $field, $records) {
-        return $this->toDate($stream->getLong(), $stream->getLong() / 300);
-      }
-    }');
     self::$recordsFor[0][self::T_DATETIME4]= newinstance('rdbms.tds.TdsRecord', [], '{
       public function unmarshal($stream, $field, $records) {
         return $this->toDate($stream->getShort(), $stream->getShort() * 60 / 300);

src/test/php/rdbms/unittest/integration/MsSQLIntegrationTest.class.php

@@ -171,4 +171,22 @@ public function printMessage() {
     ');
     $this->assertEquals(1, $q->next('result'));
   }
+
+  #[@test]
+  public function datetime() {
+    $cmp= new Date('2009-08-14 12:45:00');
+    $result= $this->db()->query('select cast(%s as datetime) as value', $cmp)->next('value');
+
+    $this->assertInstanceOf(Date::class, $result);
+    $this->assertEquals($cmp->toString('Y-m-d H:i:s'), $result->toString('Y-m-d H:i:s'));
+  }
+
+  #[@test]
+  public function smalldatetime() {
+    $cmp= new Date('2009-08-14 12:45:00');
+    $result= $this->db()->query('select cast(%s as smalldatetime) as value', $cmp)->next('value');
+
+    $this->assertInstanceOf(Date::class, $result);
+    $this->assertEquals($cmp->toString('Y-m-d H:i:s'), $result->toString('Y-m-d H:i:s'));
+  }
 }

src/test/php/rdbms/unittest/integration/SybaseIntegrationTest.class.php

@@ -2,6 +2,7 @@
 
 use rdbms\SQLStatementFailedException;
 use util\Bytes;
+use util\Date;
 use unittest\PrerequisitesNotMetError;
 
 /**
@@ -220,4 +221,22 @@ public function longcharImplementationRegression() {
         "bar" as "field2"
     ')->next());
   }
+
+  #[@test]
+  public function datetime() {
+    $cmp= new Date('2009-08-14 12:45:00');
+    $result= $this->db()->query('select cast(%s as datetime) as value', $cmp)->next('value');
+
+    $this->assertInstanceOf(Date::class, $result);
+    $this->assertEquals($cmp->toString('Y-m-d H:i:s'), $result->toString('Y-m-d H:i:s'));
+  }
+
+  #[@test]
+  public function smalldatetime() {
+    $cmp= new Date('2009-08-14 12:45:00');
+    $result= $this->db()->query('select cast(%s as smalldatetime) as value', $cmp)->next('value');
+
+    $this->assertInstanceOf(Date::class, $result);
+    $this->assertEquals($cmp->toString('Y-m-d H:i:s'), $result->toString('Y-m-d H:i:s'));
+  }
 }