Change default for autoconnect to true

Author: thekid

ChangeLog.md

@@ -3,6 +3,11 @@ RDBMS support for the XP Framework: MySQL, Sybase, MSSQL, PostgreSQL, SQLite3, I
 
 ## ?.?.? / ????-??-??
 
+* Changed the default for *autoconnect* to true, that is, if it is omitted
+  from the DSN, it will automatically connect. If the driver should not
+  automatically connect, add `?autoconnect=0` to the DSN.
+  (@thekid)
+
 ## 6.2.2 / 2015-06-01
 
 * Changed MySQL userland protocol to handle case when MySQL server disconnects

src/main/php/rdbms/DBConnection.class.php

@@ -30,6 +30,9 @@ abstract class DBConnection extends Observable {
   public function __construct($dsn) {
     $this->dsn= $dsn;
     $this->flags= $dsn->getFlags();
+    if (!$this->dsn->url->hasParam('autoconnect')) {
+      $this->flags |= DB_AUTOCONNECT;
+    }
     $this->setTimeout($dsn->getProperty('timeout', 0));   // 0 means no timeout
 
     // Keep this for BC reasons

src/test/php/rdbms/unittest/DBTest.class.php

@@ -15,7 +15,7 @@ class DBTest extends TestCase {
    * Setup function
    */
   public function setUp() {
-    $this->conn= DriverManager::getConnection('mock://mock/MOCKDB');
+    $this->conn= DriverManager::getConnection('mock://mock/MOCKDB?autoconnect=0');
     $this->assertEquals(0, $this->conn->flags & DB_AUTOCONNECT);
   }