XWIKI-20909: Code macro scroll controls are not keyboard accessible #4460
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira URL
https://jira.xwiki.org/browse/XWIKI-20909
Changes
Description
Clarifications
If ALL of those conditions are fulfilled, then the reported issue corresponds to an actual problem in the user experience.
scrollable-region-focusable
in the full set of WCAG tests done on XS. Once this PR is merged and its result can be confirmed on CI, we can updatexwiki-platform/xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-ui/src/main/java/org/xwiki/test/ui/WCAGContext.java
Line 126 in d701b8b
Screenshots & Video
None, test change only.
Executed Tests
Unfortunately, the test completely failed if I didn't run previous tests before, so I could not use a precise pattern. I ran
mvn clean install -f xwiki-platform-core/xwiki-platform-export/xwiki-platform-export-pdf/xwiki-platform-export-pdf-test/xwiki-platform-export-pdf-test-docker -Pdocker -Dxwiki.test.ui.wcag=true -Dit.test="PDFExportIT"
and it succeeded. Contrary to before the changes, there was no WCAGWarning found by the tests, only incompletes and passes (both are fine to keep in the build).Expected merging strategy