Skip to content
Merged
Show file tree
Hide file tree
Changes from 41 commits
Commits
Show all changes
90 commits
Select commit Hold shift + click to select a range
a76ff24
changes
20001020ycx Oct 7, 2025
697f366
changes for session states
20001020ycx Oct 7, 2025
70dff32
linting
20001020ycx Oct 8, 2025
0d8b06a
finalize get_instructions
20001020ycx Oct 8, 2025
c5ac54e
manual pass
20001020ycx Oct 9, 2025
d326f76
fine functionality wise
20001020ycx Oct 9, 2025
37f2c41
queryresult ready for pr
20001020ycx Oct 9, 2025
47d0301
sessionState ready for pr
20001020ycx Oct 9, 2025
2201266
another pass
20001020ycx Oct 9, 2025
aa37f1a
delete ai doc
20001020ycx Oct 9, 2025
a3076b6
pass for minor files
20001020ycx Oct 9, 2025
d3d7830
basically okay with functionality
20001020ycx Oct 9, 2025
ec0f2bc
fix uv formating and testing
20001020ycx Oct 9, 2025
21e0386
complete test review
20001020ycx Oct 9, 2025
edf68e4
adding multi-threading test
20001020ycx Oct 9, 2025
3d2be57
passing all tests
20001020ycx Oct 10, 2025
e1c1b3b
test docstring
20001020ycx Oct 10, 2025
7844653
Merge branch 'main' of github.com:y-scope/clp into 10-4-mcp-server-im…
20001020ycx Oct 10, 2025
97e7f23
fix docstring
20001020ycx Oct 10, 2025
d3ccf3e
pass on docstring
20001020ycx Oct 10, 2025
15315ec
addressing code rabbit
20001020ycx Oct 10, 2025
8ce8a38
addressing 2nd round of rabbit review
20001020ycx Oct 10, 2025
6faeba9
docstring fixes
20001020ycx Oct 10, 2025
466e242
add paging metadata to documentation
20001020ycx Oct 10, 2025
cccd8ec
nits
20001020ycx Oct 10, 2025
b7c3b87
update concurrency model docstring
20001020ycx Oct 10, 2025
9c6b881
supress linter
20001020ycx Oct 11, 2025
184c94e
Update components/clp-mcp-server/clp_mcp_server/server/session_manage…
20001020ycx Oct 12, 2025
07aa3f8
Update components/clp-mcp-server/clp_mcp_server/server/session_manage…
20001020ycx Oct 12, 2025
1c2d810
Update components/clp-mcp-server/clp_mcp_server/server/session_manage…
20001020ycx Oct 12, 2025
02c706f
Update components/clp-mcp-server/clp_mcp_server/server/session_manage…
20001020ycx Oct 12, 2025
da0b2e3
var renaming
20001020ycx Oct 12, 2025
142573a
Merge branch '10-4-mcp-server-implementation' of github.com:20001020y…
20001020ycx Oct 12, 2025
6f426ca
Update components/clp-mcp-server/clp_mcp_server/server/session_manage…
20001020ycx Oct 12, 2025
c8816a5
Merge branch '10-4-mcp-server-implementation' of github.com:20001020y…
20001020ycx Oct 12, 2025
702837c
address easy to fix comments
20001020ycx Oct 12, 2025
e267ec4
resolving conflicts
20001020ycx Oct 12, 2025
ed7765b
fix strings
20001020ycx Oct 12, 2025
9e73062
missed leading space
20001020ycx Oct 12, 2025
01c6a05
wrong docstring
20001020ycx Oct 12, 2025
67d183e
fix errors by latest change
20001020ycx Oct 12, 2025
ce744d7
trivial comment addressing
20001020ycx Oct 14, 2025
4fc5cc3
adding fixure test for unit test
20001020ycx Oct 14, 2025
23797fd
fix unit test var
20001020ycx Oct 14, 2025
0644fb7
fix rabbits change
20001020ycx Oct 14, 2025
662b47d
fix rabbit
20001020ycx Oct 14, 2025
1a53ad3
adding lock to enforce thread-safety
20001020ycx Oct 14, 2025
862aa42
done with impl
20001020ycx Oct 14, 2025
b79f681
sync up with chaoyue about async single thread concurrency
20001020ycx Oct 15, 2025
134591c
Update components/clp-mcp-server/clp_mcp_server/server/session_manage…
20001020ycx Oct 16, 2025
50e5db3
Update components/clp-mcp-server/clp_mcp_server/server/session_manage…
20001020ycx Oct 16, 2025
1cad6b0
Update components/clp-mcp-server/clp_mcp_server/server/session_manage…
20001020ycx Oct 16, 2025
2683bcf
Update components/clp-mcp-server/clp_mcp_server/server/server.py
20001020ycx Oct 16, 2025
22de748
code review format update
20001020ycx Oct 16, 2025
c934ac7
implement async garbage collector
20001020ycx Oct 16, 2025
4a2bd41
Update components/clp-mcp-server/clp_mcp_server/server/server.py
20001020ycx Oct 16, 2025
ad11e90
Update components/clp-mcp-server/clp_mcp_server/server/session_manage…
20001020ycx Oct 16, 2025
a1979d6
Update components/clp-mcp-server/clp_mcp_server/server/session_manage…
20001020ycx Oct 16, 2025
2193824
Update components/clp-mcp-server/clp_mcp_server/server/session_manage…
20001020ycx Oct 16, 2025
d6a7944
fix docstring
20001020ycx Oct 16, 2025
00f9503
Merge branch '10-4-mcp-server-implementation' of github.com:20001020y…
20001020ycx Oct 16, 2025
9678909
Update components/clp-mcp-server/clp_mcp_server/server/session_manage…
20001020ycx Oct 16, 2025
5af4233
Update components/clp-mcp-server/clp_mcp_server/server/session_manage…
20001020ycx Oct 16, 2025
392af88
Update components/clp-mcp-server/clp_mcp_server/server/session_manage…
20001020ycx Oct 16, 2025
07f17a5
done with docstring comment
20001020ycx Oct 16, 2025
d4f6015
Merge branch '10-4-mcp-server-implementation' of github.com:20001020y…
20001020ycx Oct 16, 2025
540e78d
done with async garbage collector
20001020ycx Oct 16, 2025
c480b33
move checking to session
20001020ycx Oct 16, 2025
c411ae0
fix docstring
20001020ycx Oct 16, 2025
2601008
Minor fix.
LinZhihao-723 Oct 16, 2025
e38f988
Merge branch '10-4-mcp-server-implementation' of https://github.com/2…
LinZhihao-723 Oct 16, 2025
08c80b3
Add instruction on how to run unit tests.
LinZhihao-723 Oct 16, 2025
1de6a46
fix unit tests
20001020ycx Oct 16, 2025
86184c9
Merge branch '10-4-mcp-server-implementation' of github.com:20001020y…
20001020ycx Oct 16, 2025
a2a13b8
Minor fix.
LinZhihao-723 Oct 16, 2025
8a5c204
Minor renaming.
LinZhihao-723 Oct 16, 2025
9caab35
hoist
20001020ycx Oct 16, 2025
f7a6579
Merge branch '10-4-mcp-server-implementation' of github.com:20001020y…
20001020ycx Oct 16, 2025
a54b019
update docstring of session manager class
20001020ycx Oct 16, 2025
046b6f6
fix ttl seconds
20001020ycx Oct 16, 2025
ebad693
Update unit tests.
LinZhihao-723 Oct 16, 2025
fa8dcc5
Merge branch '10-4-mcp-server-implementation' of https://github.com/2…
LinZhihao-723 Oct 16, 2025
5a12084
System Prompt
20001020ycx Oct 16, 2025
acf99a9
Merge branch '10-4-mcp-server-implementation' of github.com:20001020y…
20001020ycx Oct 16, 2025
3b7daca
Refactor page schema.
LinZhihao-723 Oct 16, 2025
7e7b321
Merge branch '10-4-mcp-server-implementation' of https://github.com/2…
LinZhihao-723 Oct 16, 2025
2b3f13a
Fix formating issue.
LinZhihao-723 Oct 16, 2025
c206f7b
Fix type annotation.
LinZhihao-723 Oct 16, 2025
f882168
Merge branch 'main' into 10-4-mcp-server-implementation
20001020ycx Oct 16, 2025
8e67e3d
Merge branch 'main' into 10-4-mcp-server-implementation
LinZhihao-723 Oct 17, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions components/clp-mcp-server/clp_mcp_server/server/constants.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
"""Constants for CLP MCP server."""

EXPIRED_SESSION_SWEEP_INTERVAL_SECONDS = 600 # 10 minutes
ITEM_PER_PAGE = 10
MAX_CACHED_RESULTS = 1000
SESSION_TTL_MINUTES = 60

SERVER_NAME = "clp-mcp-server"
SYSTEM_PROMPT = (
"You are an AI assistant that helps users query a log database using KQL (Kibana Query"
" Language). When given a user query, you should generate a KQL query that accurately captures"
" the user's intent. The KQL query should be as specific as possible to minimize the number of"
" log messages returned.\n"
"You should also consider the following guidelines when generating KQL queries:\n"
"- Use specific field names and values to narrow down the search.\n"
"- Avoid using wildcards (*) unless absolutely necessary, as they can lead to large result"
" sets.\n"
"- Use logical operators (AND, OR, NOT) to combine multiple conditions.\n"
"- Consider the time range of the logs you are searching. If the user specifies a time range,"
" include it in the KQL query.\n"
"- If the user query is ambiguous or lacks detail, ask clarifying questions to better"
" understand their intent before generating the KQL query.\n"
"- Always ensure that the generated KQL query is syntactically correct and can be executed"
" without errors.\n"
)
62 changes: 32 additions & 30 deletions components/clp-mcp-server/clp_mcp_server/server/server.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,25 +2,10 @@

from typing import Any

from fastmcp import FastMCP
from fastmcp import Context, FastMCP


class ProtocolConstant:
"""Constants for the CLP MCP Server."""

SERVER_NAME = "clp-mcp-server"

# Tool names
TOOL_HELLO_WORLD = "hello_world"
TOOL_GET_SERVER_INFO = "get_server_info"

@classmethod
def get_capabilities(cls) -> list[str]:
"""
Gets the capabilities of the server.
:return: A list of tool names supported by the server.
"""
return [cls.TOOL_HELLO_WORLD, cls.TOOL_GET_SERVER_INFO]
from . import constants
from .session_manager import SessionManager


def create_mcp_server() -> FastMCP:
Expand All @@ -31,22 +16,39 @@ def create_mcp_server() -> FastMCP:
:raise: Propagates `FastMCP.__init__`'s exceptions.
:raise: Propagates `FastMCP.tool`'s exceptions.
"""
mcp = FastMCP(name=ProtocolConstant.SERVER_NAME)
mcp = FastMCP(name=constants.SERVER_NAME)

session_manager = SessionManager(constants.SESSION_TTL_MINUTES)

@mcp.tool()
def get_server_info() -> dict[str, Any]:
@mcp.tool
def get_instructions(ctx: Context) -> str:
"""
Gets the MCP server's information.
Gets a pre-defined “system prompt” that guides the LLM behavior.
This function must be invoked before any other `FastMCP.tool`.

:return: The server's information with a list of capabilities.
:param ctx: The `FastMCP` context containing the metadata of the underlying MCP session.
:return: A string of “system prompt”.
"""
return {
"name": ProtocolConstant.SERVER_NAME,
"capabilities": ProtocolConstant.get_capabilities(),
"status": "running",
}
session = session_manager.get_or_create_session(ctx.session_id)
session.is_instructions_retrieved = True
return constants.SYSTEM_PROMPT

@mcp.tool
def get_nth_page(page_index: int, ctx: Context) -> dict[str, Any]:
"""
Retrieves the n-th page of a paginated response with the paging metadata from the previous
query.

:param page_index: Zero-based index, e.g., 0 for the first page.
:param ctx: The `FastMCP` context containing the metadata of the underlying MCP session.
:return: Dictionary containing paged log entries and the paging metadata if the
page `page_index` can be retrieved.
:return: Dictionary with ``{"Error": "error message describing the failure"}`` if fails to
retrieve page `page_index`.
"""
return session_manager.get_nth_page(ctx.session_id, page_index)

@mcp.tool()
@mcp.tool
def hello_world(name: str = "clp-mcp-server user") -> dict[str, Any]:
"""
Provides a simple hello world greeting.
Expand All @@ -56,7 +58,7 @@ def hello_world(name: str = "clp-mcp-server user") -> dict[str, Any]:
"""
return {
"message": f"Hello World, {name.strip()}!",
"server": ProtocolConstant.SERVER_NAME,
"server": constants.SERVER_NAME,
"status": "running",
}

Expand Down
223 changes: 223 additions & 0 deletions components/clp-mcp-server/clp_mcp_server/server/session_manager.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,223 @@
"""Session management for CLP MCP Server."""

import threading
import time
from dataclasses import dataclass, field
from datetime import datetime, timedelta, timezone
from typing import Any

from paginate import Page

from . import constants


class PaginatedQueryResult:
"""Paginates the cached log entries returned from a query's response."""

def __init__(self, result_log_entries: list[str], num_items_per_page: int) -> None:
"""
Initializes the PaginatedQueryResult.
:param result_log_entries: List of cached log entries to paginate.
:param num_items_per_page:
:raise: ValueError if the number of cached results or num_items_per_page is invalid.
"""
if len(result_log_entries) > constants.MAX_CACHED_RESULTS:
err_msg = (
f"PaginatedQueryResult exceeds maximum allowed cached results:"
f" {len(result_log_entries)} > {constants.MAX_CACHED_RESULTS}."
)
raise ValueError(err_msg)

if num_items_per_page <= 0:
err_msg = (
f"Invalid num_items_per_page: {num_items_per_page}, "
"it must be a positive integer. "
)
raise ValueError(err_msg)

self.result_log_entries = result_log_entries
self.num_items_per_page = num_items_per_page

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick | 🔵 Trivial

Optional: freeze cached results to avoid accidental mutation

Store cached entries as a tuple to uphold the “cached” contract. Page works with sequences.

-        self.result_log_entries = result_log_entries
+        # Ensure immutability of cached results
+        self.result_log_entries = tuple(result_log_entries)

Also applies to: 56-60

🤖 Prompt for AI Agents
In components/clp-mcp-server/clp_mcp_server/server/session_manager.py around
lines 39-41 (and similarly at lines 56-60), the cached result entries are
assigned as mutable lists which can be accidentally mutated; change those
assignments to store an immutable tuple (e.g., wrap the incoming sequence with
tuple(...)) so the cached contract is preserved while pages can still operate on
sequences; update both places where result_log_entries (and any other cached
collections) are stored to use tuple(...) and ensure any subsequent code treats
them as sequences, not mutable lists.

self._num_pages = (len(result_log_entries) + num_items_per_page - 1) // num_items_per_page

def get_page(self, page_index: int) -> Page | None:
"""
Returns a page from the cached query results.
:param page_index: The number of page to retrieve (zero-based index; 0 is the first page).
:return: A `Page` object for the specified page.
:return: None if `page_index` is out of bounds.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Docstring phrasing: use “page index” consistently.

Tighten wording and keep zero-based note consistent across methods.

-        :param page_index: The number of page to retrieve (zero-based index; 0 is the first page).
+        :param page_index: The page index to retrieve (zero-based; 0 is the first page).

Apply the same change in SessionState.get_page_data and SessionManager.get_nth_page.

Also applies to: 102-107, 224-226

🤖 Prompt for AI Agents
components/clp-mcp-server/clp_mcp_server/server/session_manager.py around lines
47-49 (and also update the similar docstrings at 102-107 and 224-226): the
docstrings use inconsistent phrasing for the page index and duplicate/verbose
return lines; change all occurrences to use the phrase "page index" (two words)
consistently, tighten the wording to one :param line like ":param page_index:
zero-based page index (0 is the first page)." and one :return line like
":return: A Page object for the specified page, or None if the page index is out
of bounds." Apply this same wording in SessionState.get_page_data and
SessionManager.get_nth_page docstrings at the indicated line ranges.

"""
page_number = page_index + 1 # Convert zero-based to one-based
if page_number <= 0 or self._num_pages < page_number:
return None

return Page(
self.result_log_entries,
page=page_number,
items_per_page=self.num_items_per_page,
)


@dataclass
class SessionState:
"""Represents the state of a user session."""

session_id: str
_num_items_per_page: int
_session_ttl_minutes: int

is_instructions_retrieved: bool = False
last_accessed: datetime = field(default_factory=lambda: datetime.now(timezone.utc))
_cached_query_result: PaginatedQueryResult | None = None

def cache_query_result(
self,
results: list[str],
) -> None:
"""
Caches the latest query result of the session.
:param results: Complete log entries from previous query for caching.
"""
self._cached_query_result = PaginatedQueryResult(
result_log_entries=results, num_items_per_page=self._num_items_per_page
)

def get_page_data(self, page_index: int) -> dict[str, Any]:
"""
Gets page data and its metadata in a dictionary format.
:param page_index: The number of page to retrieve (zero-based index; 0 is the first page).
:return: Dictionary containing paged log entries and the paging metadata if the
page `page_index` can be retrieved.
:return: Dictionary with ``{"Error": "error message describing the failure"}`` if fails to
retrieve page `page_index`.
"""
if self._cached_query_result is None:
return {"Error": "No previous paginated response in this session."}

page = self._cached_query_result.get_page(page_index)
if page is None:
return {"Error": "Page index is out of bounds."}

return {
"items": list(page),
"total_pages": page.page_count,
"total_items": page.item_count,
"num_items_per_page": page.items_per_page,
"has_next": page.next_page is not None,
"has_previous": page.previous_page is not None,
Comment on lines 133 to 143
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Return an empty first page when there are zero cached results.

When a search yields no hits, _num_pages is 0, so requesting index 0 returns None and we emit “Page index is out of bounds.” even though the query succeeded. Please special-case the zero-results path so page 0 returns an empty payload with the expected metadata.

-        page = self._cached_query_result.get_page(page_index)
+        cached_result = self._cached_query_result
+
+        if cached_result._num_pages == 0:
+            if page_index != 0:
+                return {"Error": "Page index is out of bounds."}
+            return {
+                "items": [],
+                "total_pages": 0,
+                "total_items": 0,
+                "num_items_per_page": cached_result.num_items_per_page,
+                "has_next": False,
+                "has_previous": False,
+            }
+
+        page = cached_result.get_page(page_index)
🤖 Prompt for AI Agents
In components/clp-mcp-server/clp_mcp_server/server/session_manager.py around
lines 125 to 135, the current code returns an "out of bounds" error when
requesting page 0 while there are zero cached results; instead detect the
zero-results case (e.g., _cached_query_result.item_count or
_cached_query_result.page_count == 0) and when page_index == 0 return an empty
page payload: items as an empty list, total_pages 0, total_items 0,
num_items_per_page 0 (or the configured page size if available), and
has_next/has_previous both False; otherwise keep the existing out-of-bounds
behavior for other invalid indexes.

}
Comment on lines 130 to 144
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Return an empty page when the cached result set is empty.

Lines 135-149 treat every zero-length cache as “Page index is out of bounds.” With _num_pages == 0, get_page(0) returns None, so even the first page of a successful empty query yields an error. Return a proper empty page payload for page_index == 0.

-        page = self._cached_query_result.get_page(page_index)
-        if page is None:
-            return {"Error": "Page index is out of bounds."}
-
-        return {
+        cached_result = self._cached_query_result
+
+        if cached_result._num_pages == 0:
+            if page_index != 0:
+                return {"Error": "Page index is out of bounds."}
+            return {
+                "items": [],
+                "total_pages": 0,
+                "total_items": 0,
+                "num_items_per_page": self._num_items_per_page,
+                "has_next": False,
+                "has_previous": False,
+            }
+
+        page = cached_result.get_page(page_index)
+        if page is None:
+            return {"Error": "Page index is out of bounds."}
+
+        return {
             "items": list(page),
             "total_pages": page.page_count,
             "total_items": page.item_count,
             "num_items_per_page": page.items_per_page,
             "has_next": page.next_page is not None,
             "has_previous": page.previous_page is not None,
         }
🤖 Prompt for AI Agents
In components/clp-mcp-server/clp_mcp_server/server/session_manager.py around
lines 135-149, the code treats a zero-length cached_query_result as
out-of-bounds because get_page(0) returns None; update the logic to special-case
an empty cached result when page_index == 0 and return a proper empty page
payload instead of an error. Specifically: if _cached_query_result is present
but _cached_query_result._num_pages == 0 and page_index == 0, return a dict with
"items": [], "total_pages": 0, "total_items": 0, "num_items_per_page": 0 (or the
cached default if available), "has_next": False, and "has_previous": False;
otherwise keep the existing out-of-bounds handling for other page_index values.


def is_expired(self) -> bool:
""":return: Whether the session has expired."""
time_diff = datetime.now(timezone.utc) - self.last_accessed
return time_diff > timedelta(minutes=self._session_ttl_minutes)

def update_access_time(self) -> None:
"""Updates the last accessed timestamp."""
self.last_accessed = datetime.now(timezone.utc)


class SessionManager:
"""
Session manager for concurrent user sessions.
`SessionManager` respects MCP Server Concurrency Model, that is:
The server supports multiple concurrent clients, where each client only makes synchronous
API calls.
This model leads to the following design decisions:
sessions is a shared variable as there may be multiple session attached to the MCP server
session state is NOT a shared variable because each session is accessed by only one
connection at a time because API calls for a single session are synchronous.
"""

def __init__(self, session_ttl_minutes: int) -> None:
"""
Initializes the SessionManager and starts background cleanup thread.
:param session_ttl_minutes: Session time-to-live in minutes.
"""
self.sessions: dict[str, SessionState] = {}
self._session_ttl_minutes = session_ttl_minutes
self._sessions_lock = threading.Lock()
self._cleanup_thread = threading.Thread(target=self._cleanup_loop, daemon=True)
self._cleanup_thread.start()

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick | 🔵 Trivial

Make cleanup thread optional and stoppable (testability, clean shutdown)

Always starting a daemon thread complicates tests and shutdown. Add a flag and stop() with an Event.

-    def __init__(self, session_ttl_minutes: int) -> None:
+    def __init__(self, session_ttl_minutes: int, start_cleanup_thread: bool = True) -> None:
         """
         Initializes the SessionManager and starts background cleanup thread.
 
         :param session_ttl_minutes: Session time-to-live in minutes.
         """
         self.sessions: dict[str, SessionState] = {}
         self._session_ttl_minutes = session_ttl_minutes
         self._sessions_lock = threading.Lock()
-        self._cleanup_thread = threading.Thread(target=self._cleanup_loop, daemon=True)
-        self._cleanup_thread.start()
+        self._stop_event = threading.Event()
+        self._cleanup_thread: threading.Thread | None = None
+        if start_cleanup_thread:
+            self._cleanup_thread = threading.Thread(target=self._cleanup_loop, daemon=True)
+            self._cleanup_thread.start()
 
     def _cleanup_loop(self) -> None:
         """Cleans up all expired sessions periodically in a separate cleanup thread."""
-        while True:
-            time.sleep(constants.EXPIRED_SESSION_SWEEP_INTERVAL_SECONDS)
-            self.cleanup_expired_sessions()
+        while not self._stop_event.is_set():
+            # Wait allows prompt exit when stop() is called
+            self._stop_event.wait(constants.EXPIRED_SESSION_SWEEP_INTERVAL_SECONDS)
+            if self._stop_event.is_set():
+                break
+            self.cleanup_expired_sessions()
+
+    def stop(self) -> None:
+        """Stops the background cleanup thread (primarily for tests)."""
+        if hasattr(self, "_stop_event"):
+            self._stop_event.set()
+        t = getattr(self, "_cleanup_thread", None)
+        if t is not None and t.is_alive():
+            t.join(timeout=1)

Also applies to: 190-195

def _cleanup_loop(self) -> None:
"""Cleans up all expired sessions periodically in a separate cleanup thread."""
while True:
time.sleep(constants.EXPIRED_SESSION_SWEEP_INTERVAL_SECONDS)
self.cleanup_expired_sessions()

def cleanup_expired_sessions(self) -> None:
"""Cleans up all expired sessions."""
with self._sessions_lock:
expired_sessions = [
sid for sid, session in self.sessions.items() if session.is_expired()
]

for sid in expired_sessions:
del self.sessions[sid]

def get_or_create_session(self, session_id: str) -> SessionState:
"""
Gets an existing session or creates a new one.
:param session_id: Unique identifier for the session.
:return: The SessionState object for the given session_id.
"""
with self._sessions_lock:
if session_id in self.sessions and self.sessions[session_id].is_expired():
del self.sessions[session_id]

if session_id not in self.sessions:
self.sessions[session_id] = SessionState(
session_id, constants.ITEM_PER_PAGE, self._session_ttl_minutes
)

session = self.sessions[session_id]

session.update_access_time()
return session

def cache_query_result(self, session_id: str, query_results: list[str]) -> dict[str, Any]:
"""
Caches query results for a session and returns the first page and the paging metadata.
:param session_id: Unique identifier for the session.
:param query_results: Complete log entries from previous query for caching.
:return: Dictionary containing the first page log entries and the paging metadata if the
first page can be retrieved.
:return: Dictionary with ``{"Error": "error message describing the failure"}`` if fails to
retrieve the first page.
"""
session = self.get_or_create_session(session_id)
if session.is_instructions_retrieved is False:
return {
"Error": "Please call get_instructions() first "
"to understand how to use this MCP server."
}

session.cache_query_result(results=query_results)

return session.get_page_data(0)

def get_nth_page(self, session_id: str, page_index: int) -> dict[str, Any]:
"""
Retrieves the n-th page of a paginated response with the paging metadata from the previous
query.
:param session_id: Unique identifier for the session.
:param page_index: The number of page to retrieve (zero-based index; 0 is the first page).
:return: Forwards `SessionState.get_page_data`'s return values.
"""
session = self.get_or_create_session(session_id)
if session.is_instructions_retrieved is False:
return {
"Error": "Please call get_instructions() first "
"to understand how to use this MCP server."
}

return session.get_page_data(page_index)
22 changes: 12 additions & 10 deletions components/clp-mcp-server/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,12 @@ authors = [{name = "YScope Inc.", email = "dev@yscope.com"}]
readme = "README.md"
requires-python = ">=3.10"
dependencies = [
"aiomysql>=0.2.0",
"click>=8.3.0",
"fastmcp>=2.12.4",
"pymongo>=4.15.1",
"aiomysql>=0.2.0",
"msgpack>=1.1.1",
"paginate>=0.5.7",
"pymongo>=4.15.1",
]

[project.scripts]
Expand All @@ -23,10 +24,11 @@ build-backend = "hatchling.build"
[dependency-groups]
dev = [
"mypy>=1.16.0",
"ruff>=0.11.12",
"pytest>=8.4.1",
"pytest-env>=1.1.5",
"pytest-asyncio>=1.2.0",
"pytest-env>=1.1.5",
"pytest-repeat>=0.9.4",
"ruff>=0.11.12",
]

[tool.hatch.metadata]
Expand Down Expand Up @@ -69,12 +71,12 @@ ignore = [
]
isort.order-by-type = false

[tool.ruff.lint.per-file-ignores]
"tests/**" = [
"S101", # Allow usage of pytest `assert`
"TC003", # Ignore performance overhead of imports only used for type checking
]

[tool.ruff.format]
docstring-code-format = true
docstring-code-line-length = 100

[tool.ruff.lint.per-file-ignores]
"tests/test_clp_connector.py" = [
"INP001", # Allow implicit namespace package for tests
"S101", # Allow "assert" in test cases
]
1 change: 1 addition & 0 deletions components/clp-mcp-server/tests/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
"""Test Package for CLP MCP Server."""
Loading
Loading