refactor: Remove code path for non-delimited schema. #159
Description
Request
Previously Log Surgeon was designed to handle both delimited and non-delimited logs. However, all use cases we have come across for human readable logs contain delimiters. The majority of Log Surgeon's implementation and performance considerations have therefore been designed with delimiters in mind. In fact, there are no unit-tests or guarantees for the correctness and performance of the non-delimited schema code path.
With this in mind, it would be best to remove this code path and explicitly assume that the schema has delimiters (and continue to error out if it doesn't as we already do). This will also ensure that if non-delimited logs are ever investigated in the future, that it is clear that the entire design of Log Surgeon should be reconsidered, and that we should not rely on any previous considerations having been made for this case.
Possible implementation
Remove m_has_delimiters and get_has_delimiter from the Lexer class, as well as all its uses.