From 0ce7e56eab02785077fbb3892b3e9b6ec6f5f0e4 Mon Sep 17 00:00:00 2001 From: mrazauskas Date: Tue, 13 May 2025 13:42:12 +0300 Subject: [PATCH] feat!: do not always include the changelog file --- .yarn/versions/e75b966c.yml | 33 +++++++++++++++++++ .../sources/commands/pack.test.js | 19 ----------- packages/plugin-pack/sources/packUtils.ts | 3 -- 3 files changed, 33 insertions(+), 22 deletions(-) create mode 100644 .yarn/versions/e75b966c.yml diff --git a/.yarn/versions/e75b966c.yml b/.yarn/versions/e75b966c.yml new file mode 100644 index 000000000000..ec7d66cb9f6c --- /dev/null +++ b/.yarn/versions/e75b966c.yml @@ -0,0 +1,33 @@ +releases: + "@yarnpkg/builder": major + "@yarnpkg/cli": major + "@yarnpkg/core": major + "@yarnpkg/doctor": major + "@yarnpkg/extensions": major + "@yarnpkg/nm": major + "@yarnpkg/plugin-compat": major + "@yarnpkg/plugin-constraints": major + "@yarnpkg/plugin-dlx": major + "@yarnpkg/plugin-essentials": major + "@yarnpkg/plugin-exec": major + "@yarnpkg/plugin-file": major + "@yarnpkg/plugin-git": major + "@yarnpkg/plugin-github": major + "@yarnpkg/plugin-http": major + "@yarnpkg/plugin-init": major + "@yarnpkg/plugin-interactive-tools": major + "@yarnpkg/plugin-jsr": major + "@yarnpkg/plugin-link": major + "@yarnpkg/plugin-nm": major + "@yarnpkg/plugin-npm": major + "@yarnpkg/plugin-npm-cli": major + "@yarnpkg/plugin-pack": major + "@yarnpkg/plugin-patch": major + "@yarnpkg/plugin-pnp": major + "@yarnpkg/plugin-pnpm": major + "@yarnpkg/plugin-stage": major + "@yarnpkg/plugin-typescript": major + "@yarnpkg/plugin-version": major + "@yarnpkg/plugin-workspace-tools": major + "@yarnpkg/pnpify": major + "@yarnpkg/sdks": major diff --git a/packages/acceptance-tests/pkg-tests-specs/sources/commands/pack.test.js b/packages/acceptance-tests/pkg-tests-specs/sources/commands/pack.test.js index a53b5de45c5d..cb266dc400bc 100644 --- a/packages/acceptance-tests/pkg-tests-specs/sources/commands/pack.test.js +++ b/packages/acceptance-tests/pkg-tests-specs/sources/commands/pack.test.js @@ -614,25 +614,6 @@ describe(`Commands`, () => { }), ); - test( - `it should always include CHANGELOG (and its variants), even with a "files" field`, - makeTemporaryEnv({ - files: [ - `/lib/*.js`, - ], - }, async ({path, run, source}) => { - await fsUtils.writeFile(`${path}/lib/changelog`, `lib specific changelog`); - await fsUtils.writeFile(`${path}/CHANGELOG.md`, `package changelog`); - - await run(`install`); - - const {stdout} = await run(`pack`, `--dry-run`); - expect(stdout).not.toMatch(/lib\/changelog/); - expect(stdout).toMatch(/CHANGELOG\.md/); - expect(stdout).toMatch(/package\.json/); - }), - ); - test( `it should never set the +x flag on files in general`, makeTemporaryEnv({}, async ({path, run, source}) => { diff --git a/packages/plugin-pack/sources/packUtils.ts b/packages/plugin-pack/sources/packUtils.ts index 636bd8c44eb6..29d00b2c0c58 100644 --- a/packages/plugin-pack/sources/packUtils.ts +++ b/packages/plugin-pack/sources/packUtils.ts @@ -18,9 +18,6 @@ const NEVER_IGNORE = [ `/licence`, `/licence.*`, - - `/changelog`, - `/changelog.*`, ]; const ALWAYS_IGNORE = [