Skip to content

feat!: do not always include the changelog file #6794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat!: do not always include the changelog file #6794

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ce7e56
feat!: do not always include the changelog file
mrazauskas May 13, 2025
0b36746
Merge branch 'master' into do-not-include-changelog
mrazauskas Jun 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions .yarn/versions/e75b966c.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
releases:
"@yarnpkg/builder": major
"@yarnpkg/cli": major
"@yarnpkg/core": major
"@yarnpkg/doctor": major
"@yarnpkg/extensions": major
"@yarnpkg/nm": major
"@yarnpkg/plugin-compat": major
"@yarnpkg/plugin-constraints": major
"@yarnpkg/plugin-dlx": major
"@yarnpkg/plugin-essentials": major
"@yarnpkg/plugin-exec": major
"@yarnpkg/plugin-file": major
"@yarnpkg/plugin-git": major
"@yarnpkg/plugin-github": major
"@yarnpkg/plugin-http": major
"@yarnpkg/plugin-init": major
"@yarnpkg/plugin-interactive-tools": major
"@yarnpkg/plugin-jsr": major
"@yarnpkg/plugin-link": major
"@yarnpkg/plugin-nm": major
"@yarnpkg/plugin-npm": major
"@yarnpkg/plugin-npm-cli": major
"@yarnpkg/plugin-pack": major
"@yarnpkg/plugin-patch": major
"@yarnpkg/plugin-pnp": major
"@yarnpkg/plugin-pnpm": major
"@yarnpkg/plugin-stage": major
"@yarnpkg/plugin-typescript": major
"@yarnpkg/plugin-version": major
"@yarnpkg/plugin-workspace-tools": major
"@yarnpkg/pnpify": major
"@yarnpkg/sdks": major
19 changes: 0 additions & 19 deletions packages/acceptance-tests/pkg-tests-specs/sources/commands/pack.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -614,25 +614,6 @@ describe(`Commands`, () => {
}),
);

test(
`it should always include CHANGELOG (and its variants), even with a "files" field`,
makeTemporaryEnv({
files: [
`/lib/*.js`,
],
}, async ({path, run, source}) => {
await fsUtils.writeFile(`${path}/lib/changelog`, `lib specific changelog`);
await fsUtils.writeFile(`${path}/CHANGELOG.md`, `package changelog`);

await run(`install`);

const {stdout} = await run(`pack`, `--dry-run`);
expect(stdout).not.toMatch(/lib\/changelog/);
expect(stdout).toMatch(/CHANGELOG\.md/);
expect(stdout).toMatch(/package\.json/);
}),
);

test(
`it should never set the +x flag on files in general`,
makeTemporaryEnv({}, async ({path, run, source}) => {
Expand Down
3 changes: 0 additions & 3 deletions packages/plugin-pack/sources/packUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,6 @@ const NEVER_IGNORE = [

`/licence`,
`/licence.*`,

`/changelog`,
`/changelog.*`,
];

const ALWAYS_IGNORE = [
Expand Down