Refactors the nm hoister to avoid tree structures #6852
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This is mostly an experiment, I'm not sure I want to really merge it right about now.
What's the problem this PR addresses?
I'm playing with porting the nm hoister, and the tree data structure can make things impractical. I'm also interested into avoiding recursive data structures to make the memory access faster.
How did you fix it?
This diff attempts to "flatten" the tree by turning recursive data structures into a flat array we reference through cell indices. So for example instead of:
We instead have:
It makes some things harder, but other things slightly easier.
Checklist