Optimise dedupe to skip install when nothing to dedupe#6974
Open
jordanoverbye wants to merge 1 commit intoyarnpkg:masterfrom
Open
Optimise dedupe to skip install when nothing to dedupe#6974jordanoverbye wants to merge 1 commit intoyarnpkg:masterfrom
jordanoverbye wants to merge 1 commit intoyarnpkg:masterfrom
Conversation
jordanoverbye
force-pushed
the
joverbye-dedupe-optimisation
branch
from
c674609 to
2577eed
Compare
Member
|
Only LGTM, but I'd like to have a second pair of eyes to look over it. |
jordanoverbye
force-pushed
the
joverbye-dedupe-optimisation
branch
from
2a34bf8 to
08a853a
Compare
Author
|
Thank you for the review @clemyan! I've just pushed a change to the versions file so only |
jordanoverbye
force-pushed
the
joverbye-dedupe-optimisation
branch
from
2ba936d to
161675d
Compare
clemyan
approved these changes
Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
Currently the
dedupecommand always runsproject.installWithNewReport()even when no packages need deduplication, causing unnecessary installs and lockfile updates.How did you fix it?
Exit early if no packages need deduping. Only run
project.installWithNewReport()when necessary.Checklist