Skip to content

Fix file descriptors (sockets) leak due to leak urlopen requests #4294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix file descriptors (sockets) leak due to leak urlopen requests #4294

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion autoload/youcompleteme.vim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -773,6 +773,7 @@ function! s:AbortAutohoverRequest() abort
let request = requests[ request_id ]
if request.origin == 'autohover'
call remove( s:pollers.command.requests, request_id )
py3 ycm_state.FlushCommandRequest( int( vim.eval( "request_id" ) ) )
call request.callback( '' )
endif
endfor
Expand Down Expand Up @@ -1551,7 +1552,7 @@ function! s:PollCommands( timer_id ) abort

" This request is done
call remove( s:pollers.command.requests, request_id )
py3 ycm_state.FlushCommandRequest( vim.eval( "request_id" ) )
py3 ycm_state.FlushCommandRequest( int( vim.eval( "request_id" ) ) )
call request[ 'callback' ]( result )
endfor

Expand Down
4 changes: 4 additions & 0 deletions python/ycm/unsafe_thread_pool_executor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,10 @@ def _worker( executor_reference, work_queue ):
work_item = work_queue.get( block=True )
if work_item is not None:
work_item.run()
# Delete references to object,
# whis allow remove object by GC without stuck on work_queue.get()
# on next cycle iteration. See GH-60488
del work_item
continue
executor = executor_reference()
# Exit if:
Expand Down