Support tracing in SDK and add loading to OpenTelemetry client #517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gazizonoki
requested changes
Jun 3, 2025
There was a problem hiding this comment.
- Нет разметки спанами
- Где-то отсутствует реализация
- В CMake не вписана зависимость на opentelemetry библиотеку
- Надо сделать CMake флаг, чтобы явно включать opentelemetry плагин. Если пользователю он не нужен, не надо делать зависимость кода от него, на то это и плагин
Gazizonoki
requested changes
Jun 5, 2025
| @@ -85,4 +90,4 @@ target_include_directories(nayuki_md5 PUBLIC | |||
| $<INSTALL_INTERFACE:third_party/nayuki_md5> | |||
| ) | |||
|
|
|||
| _ydb_sdk_install_targets(TARGETS nayuki_md5) | |||
| _ydb_sdk_install_targets(TARGETS nayuki_md5) | |||
There was a problem hiding this comment.
Отступы в CMakeLists везде по 2 пробела
| @@ -7,6 +7,8 @@ option(YDB_SDK_EXAMPLES "Build YDB C++ SDK examples" On) | |||
| set(YDB_SDK_GOOGLE_COMMON_PROTOS_TARGET "" CACHE STRING "Name of cmake target preparing google common proto library") | |||
| option(YDB_SDK_USE_RAPID_JSON "Search for rapid json library in system" ON) | |||
|
|
|||
| option(YDB_SDK_TRACING "Enable tracing support" ON) | |||
There was a problem hiding this comment.
Флаг не совсем корректно назван, мы включаем не трейсинг целиком, мы включаем именно конкретный opentelemetry плагин
| else() | ||
| target_link_libraries(tracing_example PRIVATE ydb-cpp-sdk) | ||
| target_compile_definitions(tracing_example PRIVATE -DYDB_SDK_TRACING_DISABLED) | ||
| endif() |
There was a problem hiding this comment.
- Таргета ydb-cpp-sdk нет
- Более чистым будет линковаться c opentelemetry-cpp так:
target_link_libraries(tracing_example PRIVATE opentelemetry-cpp::api)- Если opentelemetry вырублен, example в принципе собирать не надо
There was a problem hiding this comment.
- Почему это header файлы?
- otel_tracer не нужно компилировать, если проставлен флаг
- А как эти трейсеры создать теперь? Надо создать папку plugins в include и src по правильному. Там будет папка для otel_tracer и в нем будет фабричный метод. А то сейчас все в кучу слеплено
|
Все еще нет разметки спанами |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.