-
Notifications
You must be signed in to change notification settings - Fork 15
feat: add setting to select syntax in acl handlers #2474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a new user setting for selecting the ACL syntax format and integrates the selection (via a dialect/ACL syntax parameter) throughout the ACL-related API calls, selectors, and UI components.
- Introduces ACL_SYNTAX_KEY and AclSyntax enum in constants.
- Adds the useAclSyntax hook to retrieve the user-selected ACL syntax.
- Updates API, selectors, and various components to pass the new dialect parameter.
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
src/utils/hooks/useAclSyntax.ts | New hook to read ACL syntax from user settings. |
src/utils/constants.ts | Adds ACL_SYNTAX_KEY and AclSyntax enum with supported syntax values. |
src/store/reducers/schemaAcl/schemaAcl.ts | Updates endpoints and selectors to accept the new dialect parameter. |
src/services/settings.ts | Updates default settings to include ACL syntax selection. |
src/services/api/viewer.ts | Modifies API methods to accept and pass the dialect parameter. |
Other container and UI components | Integrates the new setting via useAclSyntax and passes dialect accordingly. |
Comments suppressed due to low confidence (1)
src/services/api/viewer.ts:194
- [nitpick] Consider renaming the 'dialect' parameter to 'aclSyntax' (or a similar term) to better reflect its purpose and maintain consistency with the rest of the codebase.
) {
added test |
Close #2401
Stand
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
Test Changes Summary ✨1 ⏭️3
✨ New Tests (1)
⏭️ Skipped Tests (3)
Bundle Size: 🔺
Current: 84.00 MB | Main: 83.99 MB
Diff: +6.14 KB (0.01%)
ℹ️ CI Information