Skip to content

feat: add setting to select syntax in acl handlers #2474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 25, 2025
Merged

Conversation

astandrik
Copy link
Collaborator

@astandrik astandrik commented Jun 24, 2025

Close #2401

Stand

CI Results

Test Status: ⚠️ FLAKY

📊 Full Report

Total Passed Failed Flaky Skipped
344 338 0 1 5
Test Changes Summary ✨1 ⏭️3

✨ New Tests (1)

  1. Effective rights display changes when switching ACL syntax (tenant/diagnostics/tabs/access.test.ts)

⏭️ Skipped Tests (3)

  1. Query tab first row has values for all columns in Top mode (tenant/diagnostics/tabs/queries.test.ts)
  2. Scroll to row, get shareable link, navigate to URL and verify row is scrolled into view (tenant/diagnostics/tabs/queries.test.ts)
  3. TopShards tab first row has values for all columns in History mode (tenant/diagnostics/tabs/topShards.test.ts)

Bundle Size: 🔺

Current: 84.00 MB | Main: 83.99 MB
Diff: +6.14 KB (0.01%)

⚠️ Bundle size increased. Please review.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new user setting for selecting the ACL syntax format and integrates the selection (via a dialect/ACL syntax parameter) throughout the ACL-related API calls, selectors, and UI components.

  • Introduces ACL_SYNTAX_KEY and AclSyntax enum in constants.
  • Adds the useAclSyntax hook to retrieve the user-selected ACL syntax.
  • Updates API, selectors, and various components to pass the new dialect parameter.

Reviewed Changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/utils/hooks/useAclSyntax.ts New hook to read ACL syntax from user settings.
src/utils/constants.ts Adds ACL_SYNTAX_KEY and AclSyntax enum with supported syntax values.
src/store/reducers/schemaAcl/schemaAcl.ts Updates endpoints and selectors to accept the new dialect parameter.
src/services/settings.ts Updates default settings to include ACL syntax selection.
src/services/api/viewer.ts Modifies API methods to accept and pass the dialect parameter.
Other container and UI components Integrates the new setting via useAclSyntax and passes dialect accordingly.
Comments suppressed due to low confidence (1)

src/services/api/viewer.ts:194

  • [nitpick] Consider renaming the 'dialect' parameter to 'aclSyntax' (or a similar term) to better reflect its purpose and maintain consistency with the rest of the codebase.
    ) {

artemmufazalov
artemmufazalov previously approved these changes Jun 24, 2025
@astandrik
Copy link
Collaborator Author

added test

@astandrik astandrik added this pull request to the merge queue Jun 25, 2025
Merged via the queue into main with commit e5e6f3a Jun 25, 2025
7 checks passed
@astandrik astandrik deleted the astandrik.2401 branch June 25, 2025 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add setting to select syntax in ACL handlers
3 participants