Add Russian greeting functionality to YDB embedded UI #2578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Raubzeug <42094364+Raubzeug@users.noreply.github.com>
Copilot
AI
changed the title
Copilot finished work on behalf of
Raubzeug
July 16, 2025 11:52
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a minimal Russian greeting functionality as requested in the issue. The change adds "привет" (hello) to the YDB embedded UI cluster overview section.
Changes Made
Internationalization (i18n) Updates
src/containers/Cluster/i18n/ru.json- Complete Russian translation file for the Cluster component, including the new greetingsrc/containers/Cluster/i18n/en.json- Added "Hello" greeting for consistencysrc/containers/Cluster/i18n/index.ts- Modified to import both Russian and English translationsUI Implementation
src/containers/Cluster/ClusterOverview/ClusterOverview.tsx- Modified the overview title to display the greeting alongside the existing "Overview" textTesting
src/containers/Cluster/__test__/greeting.test.ts- Unit test to verify the greeting functionality works correctlyTechnical Details
The implementation follows existing patterns in the codebase:
@gravity-ui/i18nValidation
Screenshot
Note: The screenshot shows the UI in a state where it displays a "Network Error" because no YDB backend is running. This is expected behavior. When connected to a YDB instance, the greeting will appear in the cluster overview section title.
The greeting functionality will be visible in the cluster overview section when the application is connected to a YDB cluster instance.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.