feat: add network section #2621
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bugbot run |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new Network section to the tenant diagnostics page, implementing network monitoring capabilities. The Network section provides two tabs for viewing nodes by ping time and clock skew metrics.
- Adds network tab to the metrics overview with dedicated components for ping and skew analysis
- Creates reusable network metric formatting utilities for speed-based legends
- Implements tabbed interface for viewing top nodes by ping time and clock skew
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/utils/metrics/formatMetricLegend.ts | Adds formatSpeedLegend function for network speed formatting |
| src/store/reducers/tenant/types.ts | Adds TenantNetworkTab type definition |
| src/store/reducers/tenant/constants.ts | Adds network tab constants and IDs |
| src/containers/Tenant/Diagnostics/TenantOverview/i18n/en.json | Updates i18n keys for network section |
| src/containers/Tenant/Diagnostics/TenantOverview/TenantOverview.tsx | Integrates TenantNetwork component |
| src/containers/Tenant/Diagnostics/TenantOverview/TenantNetwork/* | Implements network monitoring components and utilities |
| src/containers/Tenant/Diagnostics/TenantOverview/TabCard/* | Removes clickable prop and simplifies styling |
| src/containers/Tenant/Diagnostics/TenantOverview/MetricsTabs/MetricsTabs.tsx | Adds network card with proper formatting and navigation |
Comments suppressed due to low confidence (1)
src/containers/Tenant/Diagnostics/TenantOverview/TenantNetwork/columns.ts:40
- The use of 'as any' type assertion bypasses TypeScript's type checking and should be avoided. Consider properly typing the fieldsRequired parameter or using a more specific type assertion.
})),
src/containers/Tenant/Diagnostics/TenantOverview/TenantNetwork/TopNodesBySkew.tsx
Show resolved
Hide resolved
| export function TenantNetwork({tenantName, additionalNodesProps}: TenantNetworkProps) { | ||
| const {networkTab, handleNetworkTabChange} = useTenantNetworkQueryParams(); | ||
|
|
||
| const renderTabContent = () => { |
There was a problem hiding this comment.
There is no data in network tables, but there is data in separate Network tab
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2448
Stand
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
Test Changes Summary ⏭️2
⏭️ Skipped Tests (2)
Bundle Size: 🔺
Current: 85.30 MB | Main: 85.22 MB
Diff: +0.08 MB (0.09%)
ℹ️ CI Information