fix: add network section #2635
Merged
fix: add network section #2635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bugbot run |
There was a problem hiding this comment.
Pull Request Overview
This PR adds a network section to the tenant diagnostics interface, providing visibility into network statistics such as ping times and clock skew across nodes. This enhancement extends the existing tenant overview with network monitoring capabilities.
Key changes:
- Adds network tab to tenant metrics with ping time and clock skew views
- Implements network speed formatting utilities for metrics display
- Creates dedicated components for displaying top nodes by network performance
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/utils/metrics/formatMetricLegend.ts |
Adds formatSpeedLegend function for formatting network speed metrics |
src/store/reducers/tenant/types.ts |
Adds TenantNetworkTab type definition |
src/store/reducers/tenant/constants.ts |
Adds network tab constants including ping and skew subtabs |
src/containers/Tenant/Diagnostics/TenantOverview/i18n/en.json |
Updates internationalization strings for network features |
src/containers/Tenant/Diagnostics/TenantOverview/TenantOverview.tsx |
Integrates network component into main overview |
src/containers/Tenant/Diagnostics/TenantOverview/TenantNetwork/useTenantNetworkQueryParams.ts |
Handles URL query parameters for network tab state |
src/containers/Tenant/Diagnostics/TenantOverview/TenantNetwork/columns.ts |
Defines table columns for ping and skew views |
src/containers/Tenant/Diagnostics/TenantOverview/TenantNetwork/TopNodesBySkew.tsx |
Component displaying nodes sorted by clock skew |
src/containers/Tenant/Diagnostics/TenantOverview/TenantNetwork/TopNodesByPing.tsx |
Component displaying nodes sorted by ping time |
src/containers/Tenant/Diagnostics/TenantOverview/TenantNetwork/TenantNetwork.tsx |
Main network section component with tab navigation |
src/containers/Tenant/Diagnostics/TenantOverview/TenantNetwork/TenantNetwork.scss |
Styling for network section layout |
src/containers/Tenant/Diagnostics/TenantOverview/TabCard/TabCard.tsx |
Removes unused clickable prop from TabCard component |
src/containers/Tenant/Diagnostics/TenantOverview/TabCard/TabCard.scss |
Simplifies CSS by removing conditional clickable styling |
src/containers/Tenant/Diagnostics/TenantOverview/MetricsTabs/MetricsTabs.tsx |
Integrates network card into metrics tabs with proper formatting |
src/containers/Tenant/Diagnostics/TenantOverview/TenantNetwork/useTenantNetworkQueryParams.ts
Show resolved
Hide resolved
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
astandrik
force-pushed
the
astandrik.2448-3
branch
from
1376bff to
130f828
Compare
Raubzeug
approved these changes
Jul 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2448
Stand
CI Results
Test Status: ❌ FAILED
📊 Full Report
Test Changes Summary ⏭️2
⏭️ Skipped Tests (2)
Bundle Size: 🔺
Current: 85.35 MB | Main: 85.33 MB
Diff: +0.02 MB (0.02%)
ℹ️ CI Information