Skip to content

fix: do not remove build from versions #2688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 8, 2025

Conversation

artemmufazalov
Copy link
Member

@artemmufazalov artemmufazalov commented Aug 8, 2025

Closes #2678

Previously we had versions in format ydb-stable-25-2-3 and removed build version (4 number), now it is a common practice to use build version - we have many versions in format ydb-stable-25-1-2-18

Why it is needed:

  1. To properly change colors for build versions too: ydb-stable-25-1-2-18 may have different color variant from ydb-stable-25-1-2-12
  2. To allow selecting these specific versions in versions selector on clusters page

CI Results

Test Status: ⚠️ FLAKY

📊 Full Report

Total Passed Failed Flaky Skipped
358 352 0 4 2
Test Changes Summary ⏭️2

⏭️ Skipped Tests (2)

  1. Scroll to row, get shareable link, navigate to URL and verify row is scrolled into view (tenant/diagnostics/tabs/queries.test.ts)
  2. Copy result button copies to clipboard (tenant/queryEditor/queryEditor.test.ts)

Bundle Size: ✅

Current: 85.32 MB | Main: 85.32 MB
Diff: 0.33 KB (-0.00%)

✅ Bundle size unchanged.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

@artemmufazalov artemmufazalov marked this pull request as ready for review August 8, 2025 12:07
@artemmufazalov artemmufazalov added this pull request to the merge queue Aug 8, 2025
Merged via the queue into main with commit 91c3844 Aug 8, 2025
7 checks passed
@artemmufazalov artemmufazalov deleted the 2678-do-not-remove-build branch August 8, 2025 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not remove build version in clusters versions selector
2 participants