Skip to content

Commit 1a85c10

Browse files
authored
Merge pull request #1362 fix oauth test logs and remove many time execution
2 parents e15e499 + 7c6d1a7 commit 1a85c10

File tree

1 file changed

+25
-27
lines changed

1 file changed

+25
-27
lines changed

internal/credentials/oauth2_test.go

Lines changed: 25 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -1011,33 +1011,31 @@ func TestParseSettingsFromFile(t *testing.T) {
10111011
ExpectedError: errTokenAndTokenTypeRequired,
10121012
},
10131013
}
1014-
xtest.TestManyTimes(t, func(t testing.TB) {
1015-
for _, params := range testsParams {
1016-
var fileName string
1017-
if params.Cfg != "" {
1018-
f, err := os.CreateTemp("", "cfg-")
1019-
require.NoError(t, err)
1020-
defer os.Remove(f.Name())
1021-
_, err = f.WriteString(params.Cfg)
1022-
require.NoError(t, err)
1023-
f.Close()
1024-
fileName = f.Name()
1025-
} else {
1026-
fileName = params.CfgFile
1027-
}
1014+
for _, params := range testsParams {
1015+
var fileName string
1016+
if params.Cfg != "" {
1017+
f, err := os.CreateTemp("", "cfg-")
1018+
require.NoError(t, err)
1019+
defer os.Remove(f.Name())
1020+
_, err = f.WriteString(params.Cfg)
1021+
require.NoError(t, err)
1022+
f.Close()
1023+
fileName = f.Name()
1024+
} else {
1025+
fileName = params.CfgFile
1026+
}
10281027

1029-
client, err := NewOauth2TokenExchangeCredentialsFile(
1030-
fileName,
1031-
WithSourceInfo("TestParseSettingsFromFile"),
1032-
)
1033-
fmt.Printf("Cfg:\n%s\n", params.Cfg)
1034-
if params.ExpectedError != nil {
1035-
require.ErrorIs(t, err, params.ExpectedError)
1036-
} else {
1037-
require.NoError(t, err)
1038-
formatted := fmt.Sprint(client)
1039-
require.Equal(t, params.ExpectedFormattedCredentials, formatted)
1040-
}
1028+
client, err := NewOauth2TokenExchangeCredentialsFile(
1029+
fileName,
1030+
WithSourceInfo("TestParseSettingsFromFile"),
1031+
)
1032+
t.Logf("Cfg:\n%s\n", params.Cfg)
1033+
if params.ExpectedError != nil {
1034+
require.ErrorIs(t, err, params.ExpectedError)
1035+
} else {
1036+
require.NoError(t, err)
1037+
formatted := fmt.Sprint(client)
1038+
require.Equal(t, params.ExpectedFormattedCredentials, formatted)
10411039
}
1042-
})
1040+
}
10431041
}

0 commit comments

Comments
 (0)