Skipped nil errors in xerrors.Join(errs)

asmyasnikov · web-flow · commit 1f2cf3c64997 · 2024-07-30T21:50:08.000+03:00
diff --git a/internal/xerrors/join.go b/internal/xerrors/join.go
@@ -3,12 +3,15 @@ package xerrors
 import (
 	"fmt"
 
+	"github.com/ydb-platform/ydb-go-sdk/v3/internal/xslices"
 	"github.com/ydb-platform/ydb-go-sdk/v3/internal/xstring"
 )
 
 func Join(errs ...error) *joinError {
 	return &joinError{
-		errs: errs,
+		errs: xslices.Filter(errs, func(err error) bool {
+			return err != nil
+		}),
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -3,12 +3,15 @@ package xerrors`
`3`	`3`	`import (`
`4`	`4`	`"fmt"`
`5`	`5`
	`6`	`+ "github.com/ydb-platform/ydb-go-sdk/v3/internal/xslices"`
`6`	`7`	`"github.com/ydb-platform/ydb-go-sdk/v3/internal/xstring"`
`7`	`8`	`)`
`8`	`9`
`9`	`10`	`func Join(errs ...error) *joinError {`
`10`	`11`	`return &joinError{`
`11`		`- errs: errs,`
	`12`	`+ errs: xslices.Filter(errs, func(err error) bool {`
	`13`	`+ return err != nil`
	`14`	`+ }),`
`12`	`15`	`}`
`13`	`16`	`}`
`14`	`17`