Skip to content

Commit 2cd28c9

Browse files
authored
Merge pull request #1179 from size12/back-comp
restored WithSessionPoolKeepAliveMinSize & WithSessionPoolKeepAliveTimeout
2 parents 304cde8 + c667551 commit 2cd28c9

File tree

2 files changed

+15
-0
lines changed

2 files changed

+15
-0
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
* Restored `WithSessionPoolKeepAliveMinSize` and `WithSessionPoolKeepAliveTimeout` for backward compatibility.
12
* Fixed leak timers
23
* Changed default StartTime (time of retries for connect to server) for topic writer from 1 minute to infinite (can be overrided by WithWriterStartTimeout topic option)
34
* Added `Struct` support for `Variant` in `ydb.ParamsBuilder()`

options.go

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -432,6 +432,20 @@ func WithSessionPoolDeleteTimeout(deleteTimeout time.Duration) Option {
432432
}
433433
}
434434

435+
// WithSessionPoolKeepAliveMinSize set minimum sessions should be keeped alive in table.Client
436+
//
437+
// Deprecated: table client do not support background session keep-aliving now
438+
func WithSessionPoolKeepAliveMinSize(keepAliveMinSize int) Option {
439+
return func(ctx context.Context, c *Driver) error { return nil }
440+
}
441+
442+
// WithSessionPoolKeepAliveTimeout set timeout of keep alive requests for session in table.Client
443+
//
444+
// Deprecated: table client do not support background session keep-aliving now
445+
func WithSessionPoolKeepAliveTimeout(keepAliveTimeout time.Duration) Option {
446+
return func(ctx context.Context, c *Driver) error { return nil }
447+
}
448+
435449
// WithIgnoreTruncated disables errors on truncated flag
436450
func WithIgnoreTruncated() Option {
437451
return func(ctx context.Context, c *Driver) error {

0 commit comments

Comments
 (0)